Skip to content

Fix duplicate fetchComplete when require() re-enters a shared dep's fetch #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
robobun wants to merge 1 commit into from
Closed

Fix duplicate fetchComplete when require() re-enters a shared dep's fetch #223

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions Source/JavaScriptCore/runtime/JSMicrotask.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -861,6 +861,15 @@ static void moduleRegistryModuleSettled(JSGlobalObject* globalObject, VM& vm, st
auto* entry = uncheckedDowncast<ModuleRegistryEntry>(arguments[2]);
auto* modulePromise = uncheckedDowncast<JSPromise>(arguments[0]);
auto status = static_cast<JSPromise::Status>(payload);
#if USE(BUN_JSC_ADDITIONS)
// hostLoadImportedModule's synchronous re-entry path may have already
// called fetchComplete() and fulfilled modulePromise inline while a
// synchronous loadModule was active, leaving this queued copy redundant.
// The inline path creates its own module record; the one we'd provide
// here is a duplicate parse of the same source that nothing references.
if (modulePromise->status() != JSPromise::Status::Pending)
return;
#endif
if (status == JSPromise::Status::Fulfilled) {
auto* moduleRecord = downcast<AbstractModuleRecord>(arguments[1]);
entry->fetchComplete(globalObject, moduleRecord);
Expand Down