Skip to content

security: require auth to create a tenant (POST /v1/tenants) #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
doctatortot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

security: require auth to create a tenant (POST /v1/tenants) #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion omem-server/src/api/router.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ use crate::api::server::AppState;

pub fn build_router(state: Arc<AppState>) -> Router {
let authed_routes = Router::new()
// Tenant creation requires a valid key: any active tenant may mint
// another; anonymous callers cannot. (Was on public_routes.)
.route("/v1/tenants", post(handlers::create_tenant))
.route("/v1/memories/search", get(handlers::search_memories))
.route("/v1/memories/batch-delete", post(handlers::batch_delete))
.route("/v1/memories/all", delete(handlers::delete_all_memories))
Expand Down Expand Up @@ -104,9 +107,13 @@ pub fn build_router(state: Arc<AppState>) -> Router {
auth_middleware,
));

// NOTE: /v1/tenants (tenant + api-key minting) is intentionally NOT here.
// It lives on authed_routes so a caller must already hold a valid key to
// create another tenant. Leaving it public let anyone who could reach the
// port mint an active tenant with a working key. /health and the github
// webhook (HMAC-verified in the handler) stay public.
let public_routes = Router::new()
.route("/health", get(health))
.route("/v1/tenants", post(handlers::create_tenant))
.route(
"/v1/connectors/github/webhook",
post(handlers::github_webhook),
Expand Down
Loading