Skip to content

Scope visibility flags to compression - #1030

Open
kx0101 wants to merge 1 commit into
ouch-org:mainfrom
kx0101:fix/compress-only-visibility-flags
Open

Scope visibility flags to compression#1030
kx0101 wants to merge 1 commit into
ouch-org:mainfrom
kx0101:fix/compress-only-visibility-flags

Conversation

@kx0101

@kx0101 kx0101 commented Jul 23, 2026

Copy link
Copy Markdown

Summary

  • move --hidden and --gitignore to the compress subcommand
  • reject these flags for decompress, list, and the top-level command
  • update CLI parsing tests and help snapshots

Testing

  • cargo test
  • cargo test --no-default-features
  • cargo clippy --all-targets --all-features -- -D warnings

Closes #327

@valoq

valoq commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

LGTM, only a changelog entry is missing

@valoq
valoq self-requested a review July 28, 2026 22:39
@kx0101

kx0101 commented Jul 29, 2026

Copy link
Copy Markdown
Author

@valoq thanks for checking it out, I just added the changelog entry 😄

@marcospb19

Copy link
Copy Markdown
Member

@valoq in 0.8 I abandoned the CHANGELOG in favor of having an exhaustive list generated by GitHub when making the releases.

The problem was that the CHANGELOG was always missing entries, and other projects auto-generate the CHANGELOG with scripts based on PRs.

For example, Zed auto-generates from a nicely formatted PR description, if it's malformed the CI complains with an error.

I know giving up the CHANGELOG gave me a sunken cost fallacy feel, and I should've consulted you before doing that :/, sorry.

But now that it's done I think we need to revert the CHANGELOG change before merging this.

@kx0101
kx0101 force-pushed the fix/compress-only-visibility-flags branch from 17df120 to cc58ef0 Compare July 31, 2026 07:28
@kx0101

kx0101 commented Jul 31, 2026

Copy link
Copy Markdown
Author

@marcospb19 all good don't worry about it! happens 😄

I deleted the commit

@marcospb19

Copy link
Copy Markdown
Member

Thanks!

@marcospb19

marcospb19 commented Aug 16, 2026

Copy link
Copy Markdown
Member

wait I was about to merge but I see some commits that aren't really part of your PR, is that by accident 🤔 or did I do something wrong here

maybe this wasn't based on main?

@kx0101

kx0101 commented Aug 17, 2026

Copy link
Copy Markdown
Author

@marcospb19 the actual change was only one commit, but the branch picked up unrelated history from my fork.

I'll rebase/cherry-pick it onto the current upstream main and force-push a clean branch

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@kx0101
kx0101 force-pushed the fix/compress-only-visibility-flags branch from 0d02604 to aa76600 Compare August 17, 2026 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reduce the scope of some flags

3 participants