Feature/wasm remote3#2104
Open
thibaudk wants to merge 22 commits into
Open
Conversation
thibaudk
force-pushed
the
feature/wasm-remote3
branch
from
31beb64 to
95e5c60
Compare
jcelerier
requested changes
Jul 7, 2026
| res.set(http::field::access_control_allow_origin, "*"); | ||
| res.set(http::field::access_control_allow_methods, "GET"); | ||
|
|
||
| res.set(http::field::server, BOOST_BEAST_VERSION_STRING); |
Member
There was a problem hiding this comment.
I think this could be something more personalized for ossia
| } | ||
| catch (const std::exception& e) | ||
| { | ||
| std::cerr << "Error: " << e.what() << '\n'; |
Member
There was a problem hiding this comment.
Could this integrate more with Qt ?
| auto const address2 = net::ip::make_address("0.0.0.0"); | ||
| auto const port = static_cast<unsigned short>(std::atoi("8080")); | ||
| std::string packagesPath = score::AppContext().settings<Library::Settings::Model>().getPackagesPath().toStdString(); | ||
| m_buildWasmPath = packagesPath + "/wasm-remote/"; |
Member
There was a problem hiding this comment.
Eventually I'd like the users to be able to configure this path in the remote control settings (and even enable / disable the webserver)
| { | ||
| try | ||
| { | ||
| auto const address2 = net::ip::make_address("0.0.0.0"); |
Member
There was a problem hiding this comment.
The end-user should be able to control this and the port
|
|
||
| #include <QDir> | ||
| #include <QHostAddress> | ||
| #include <QNetworkInterface> |
jcelerier
reviewed
Jul 8, 2026
| } | ||
| } | ||
| // // Set the IP address in the remote.html file | ||
| // void |
Member
There was a problem hiding this comment.
Just remove the code it's fine
jcelerier
reviewed
Jul 8, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update remote control path
forego HTML injection
accept .wasm requests
Enable CORS