Return initial apply errors when parse config - #3531
Conversation
4cc1f2e to
20fb974
Compare
|
What we want to do is that InitialConfig should stop on the first error and UpdateConfig should continue, right? Then why not just adding an argument like
Then we don't need a new wrapper like |
I made it for future, because we probable would like to stop on error also UpdateConfig. But now I think you are right, i will rework it |
Make InitialConfig return errors from failed config application instead of only logging them, so gobgpd rejects invalid startup config such as missing peer-groups or broken policy references. Keep UpdateConfig reloads non-fatal and covered by tests.
Send sd_notify READY only after the startup config has been read and applied. This prevents systemd from seeing gobgpd as ready right before it exits on an invalid initial config, while preserving the no-config-file startup path.
20fb974 to
6ced052
Compare
Make InitialConfig return errors from failed config application instead of only
logging them, so gobgpd rejects invalid startup config such as missing peer-groups
or broken policy references. Keep UpdateConfig reloads non-fatal and covered by
tests.
Alse send sd_notify READY only after the startup config has been read and applied.
This prevents systemd from seeing gobgpd as ready right before it exits on an
invalid initial config, while preserving the no-config-file startup path.