bfd: use transport local address for BFD - #3527
Open
frezbo wants to merge 1 commit into
Open
Conversation
Bind outgoing BFD sessions to the neighbor transport local address so numbered peers use the same explicit source as BGP while preserving interface binding and kernel-selected defaults. Signed-off-by: Noel Georgi <git@frezbo.dev>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the BFD implementation to optionally bind the source IP of outgoing BFD sessions to the neighbor’s configured transport local-address, aligning BFD’s source selection with BGP when an explicit source address is configured, while keeping the existing behavior (kernel-selected source) when unset.
Changes:
- Plumbs
transport.config.local-addressthrough BgpServer → bfdServer → bfdPeer and uses it to set the local UDP bind address for outgoing BFD. - Adds tests covering local-address propagation and verifying the UDP client uses the specified local address.
- Updates BFD documentation to describe source IP selection behavior and troubleshooting guidance.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/server/server.go | Passes neighbor transport local-address into BFD peer creation and includes it in BFD peer update comparisons. |
| pkg/server/bfd_server.go | Extends peer-add event and internal add path to carry a configured local source address into BFD peers. |
| pkg/server/bfd_server_test.go | Adds/updates tests to assert local-address propagation for BFD peers (including via peer-groups). |
| pkg/server/bfd_peer.go | Adds localAddress to bfdPeer and binds UDP client to it when configured (otherwise leaves IP unset for kernel selection). |
| pkg/server/bfd_peer_test.go | Adds tests validating local UDP address construction and that dialing uses the configured local source address. |
| docs/sources/bfd.md | Documents source IP selection from transport local-address and adds troubleshooting notes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bind outgoing BFD sessions to the neighbor transport local address so numbered peers use the same explicit source as BGP while preserving interface binding and kernel-selected defaults.