Permit any data type for group_by column#2497
Open
Nakaner wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop casting the
group_by_columnto text.In my use case, I create a WMS version of OSM Carto. I have a table
water_polygonswith water bodies. It has a boolean fieldint_intermittentwhich is derived from OSM tagsintermittent=*andseasonal=*(what OSM Carto does using SQL will be done by Lua in my use case).I want to create a generalised set of polygons for lower zoom levels. The generalised set of polygons should still distinguish between permanent and intermittent water bodies. It is unnecessary to store the boolean property as text.