Skip to content

TypeConverter / OgnlOps 'double boxing' #25

Closed

Description

@marvin-enthus

Hi,

I just pushed a new branch that also addresses another 'inconsistency' issue I was fighting in the past:
The automatic Type-Conversion puts a List (or Collection) into an array by doing new Object[] { } instead of using the items of the list for the array. I think this would be the more desired behaviour. I also fixed the related unit tests from #16 / #19 respectively and added some new tests.

The commit [410dee5](secadm@410dee5f64410f98ad4171150dc19869abd7de4c] (branch TypeConverterDoubleArrayBoxing) addresses the issue.

This patch is based on #23 / #24 and so i'll create a pull request after #24 ist merged or the pull request will also provide #24. But maybe both requests can be reviewed together.

Bye,
Chris

Activity

  1. lukaszlenart commented on May 17, 2016

    @lukaszlenart
    Collaborator

    Great! I would rather push a new version based on #24 and then merge this one (and push new release), it's a safer path :)

  2. lukaszlenart commented on May 18, 2016

    @lukaszlenart
    Collaborator

    @sa-ChristianNiessner you are free to go with this :)

  3. marvin-enthus commented on May 18, 2016

    @marvin-enthus
    ContributorAuthor

    And here it is. Just got the mails about the 3.1.5 release ;)

  4. lukaszlenart commented on May 19, 2016

    @lukaszlenart
    Collaborator

    I see no objections, merge party!

  5. added a commit that references this issue on May 19, 2016
  6. lukaszlenart commented on May 19, 2016

    @lukaszlenart
    Collaborator

    Fixed by merging #26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions