Skip to content

Ensure the default user attributes section has a name#24124

Merged
klaustopher merged 1 commit into
devfrom
fix-OP-19698
Jul 6, 2026
Merged

Ensure the default user attributes section has a name#24124
klaustopher merged 1 commit into
devfrom
fix-OP-19698

Conversation

@klaustopher

Copy link
Copy Markdown
Contributor

Ticket

https://community.openproject.org/projects/OP/work_packages/OP-19698/activity

What are you trying to accomplish?

Screenshots

What approach did you choose and why?

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

@dfriquet dfriquet self-requested a review July 6, 2026 11:43
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

Warning

Flaky specs

  • rspec ./spec/features/projects/lists/columns_spec.rb[1:2:1:1]
🤖 Ask Copilot to investigate

Copy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer.

@copilot The following spec(s) are flaky in CI (first seen on PR #24124, linked for reference only):

- `rspec ./spec/features/projects/lists/columns_spec.rb[1:2:1:1]`

Treat this as a standalone task, unrelated to PR #24124. Create a new branch from origin/dev and open a new pull request targeting dev — do not stack it on PR #24124 or reuse that branch.

Follow the playbook in docs/development/testing/handling-flaky-tests/README.md to find the root cause and fix the underlying race — do not skip, delete, or weaken the spec to make it pass; disabling is a last resort per the playbook, and only with a bug ticket. Verify the fix by running the spec(s) repeatedly (e.g. `script/bulk_run_rspec --run-count 10`).

If you cannot reproduce the flake or are not confident in a fix after reasonable investigation, do not fabricate a change or skip the spec to force CI green. Instead, leave the pull request in draft and document what you tried, the suspected cause, and any leads in its description, then assign @klaustopher to take over.

Once the fix is verified, title the PR after the spec(s) it fixes, and use the PR description to explain the root cause, how the change resolves it, and the before/after results. Label the PR `flaky-spec`, assign @klaustopher, and request a review from @klaustopher.
On every commit, set @klaustopher as the sole co-author with a `Co-authored-by:` trailer (use their GitHub no-reply email so it links to their account), so it is traceable who dispatched the fix.

@klaustopher klaustopher merged commit 9576508 into dev Jul 6, 2026
20 checks passed
@klaustopher klaustopher deleted the fix-OP-19698 branch July 6, 2026 12:11
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 6, 2026
@dfriquet dfriquet removed their request for review July 6, 2026 12:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Development

Successfully merging this pull request may close these issues.

3 participants