Skip to content

[FND-114] Add hierarchy to types table #24102

Merged
mrmir merged 3 commits into
devfrom
implementation/fnd-114-add-hierarchy-to-types-table
Jul 6, 2026
Merged

[FND-114] Add hierarchy to types table #24102
mrmir merged 3 commits into
devfrom
implementation/fnd-114-add-hierarchy-to-types-table

Conversation

@mrmir

@mrmir mrmir commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Ticket

https://community.openproject.org/wp/FND-114

What are you trying to accomplish?

Screenshots

What approach did you choose and why?

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

Warning

Flaky specs

  • rspec ./modules/wikis/spec/features/admin/internal_provider_spec.rb[1:1]
🤖 Ask Copilot to investigate

Copy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer.

@copilot The following spec(s) are flaky in CI (first seen on PR #24102, linked for reference only):

- `rspec ./modules/wikis/spec/features/admin/internal_provider_spec.rb[1:1]`

Treat this as a standalone task, unrelated to PR #24102. Create a new branch from origin/dev and open a new pull request targeting dev — do not stack it on PR #24102 or reuse that branch.

Follow the playbook in docs/development/testing/handling-flaky-tests/README.md to find the root cause and fix the underlying race — do not skip, delete, or weaken the spec to make it pass; disabling is a last resort per the playbook, and only with a bug ticket. Verify the fix by running the spec(s) repeatedly (e.g. `script/bulk_run_rspec --run-count 10`).

If you cannot reproduce the flake or are not confident in a fix after reasonable investigation, do not fabricate a change or skip the spec to force CI green. Instead, leave the pull request in draft and document what you tried, the suspected cause, and any leads in its description, then assign @mrmir to take over.

Once the fix is verified, title the PR after the spec(s) it fixes, and use the PR description to explain the root cause, how the change resolves it, and the before/after results. Label the PR `flaky-spec`, assign @mrmir, and request a review from @mrmir.
On every commit, set @mrmir as the sole co-author with a `Co-authored-by:` trailer (use their GitHub no-reply email so it links to their account), so it is traceable who dispatched the fix.

@dfriquet dfriquet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that PR set up a solid ground for subtypes 👍

(TIL about the standard type)

Comment thread app/models/type.rb

@oliverguenther oliverguenther left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Behaves as I'd expect it with the scope. LGTM 👍

Comment thread app/forms/work_package_types/settings_form.rb Outdated
@mrmir mrmir force-pushed the implementation/fnd-114-add-hierarchy-to-types-table branch from cf8a1ed to d56f63e Compare July 6, 2026 10:42
@mrmir mrmir marked this pull request as ready for review July 6, 2026 11:14
@mrmir mrmir merged commit 567cc9d into dev Jul 6, 2026
14 of 16 checks passed
@mrmir mrmir deleted the implementation/fnd-114-add-hierarchy-to-types-table branch July 6, 2026 11:14
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants