Skip to content

[Internal-932] Optimise ARIA labels for inline page links and macros#24098

Draft
bsatarnejad wants to merge 11 commits into
devfrom
internal-932-optimise-aria-labels-for-inline-page-links-and-macros
Draft

[Internal-932] Optimise ARIA labels for inline page links and macros#24098
bsatarnejad wants to merge 11 commits into
devfrom
internal-932-optimise-aria-labels-for-inline-page-links-and-macros

Conversation

@bsatarnejad

Copy link
Copy Markdown
Contributor

Ticket

https://community.openproject.org/wp/INTERNAL-932

What are you trying to accomplish?

Replace generated title tooltips with descriptive ARIA labels.
Add labels for work package links and attributes, resource links, user/group mentions, and wiki page macros.
Cover server-rendered and Angular macro paths.
Add and update accessibility-focused specs.

@bsatarnejad bsatarnejad self-assigned this Jul 3, 2026
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

Warning

Flaky specs

  • rspec ./spec/features/activities/work_package/activities_spec.rb[1:5:2:2]
🤖 Ask Copilot to investigate

Copy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer.

@copilot The following spec(s) are flaky in CI (first seen on PR #24098, linked for reference only):

- `rspec ./spec/features/activities/work_package/activities_spec.rb[1:5:2:2]`

Treat this as a standalone task, unrelated to PR #24098. Create a new branch from origin/dev and open a new pull request targeting dev — do not stack it on PR #24098 or reuse that branch.

Follow the playbook in docs/development/testing/handling-flaky-tests/README.md to find the root cause and fix the underlying race — do not skip, delete, or weaken the spec to make it pass; disabling is a last resort per the playbook, and only with a bug ticket. Verify the fix by running the spec(s) repeatedly (e.g. `script/bulk_run_rspec --run-count 10`).

If you cannot reproduce the flake or are not confident in a fix after reasonable investigation, do not fabricate a change or skip the spec to force CI green. Instead, leave the pull request in draft and document what you tried, the suspected cause, and any leads in its description, then assign @bsatarnejad to take over.

Once the fix is verified, title the PR after the spec(s) it fixes, and use the PR description to explain the root cause, how the change resolves it, and the before/after results. Label the PR `flaky-spec`, assign @bsatarnejad, and request a review from @bsatarnejad.
On every commit, set @bsatarnejad as the sole co-author with a `Co-authored-by:` trailer (use their GitHub no-reply email so it links to their account), so it is traceable who dispatched the fix.

@bsatarnejad bsatarnejad force-pushed the internal-932-optimise-aria-labels-for-inline-page-links-and-macros branch from 245c5e0 to caa5f95 Compare July 6, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

1 participant