[OP#XWI-52] Removes the wiki project module

config/initializers/permissions.rb

@@ -537,32 +537,6 @@
                       permissible_on: :project
     end
 
-    map.project_module :wiki do |wiki|
-      wiki.permission :view_wiki_pages,
-                      { wiki: %i[index show special menu export] },
-                      permissible_on: :project
-
-      wiki.permission :view_wiki_edits,
-                      { wiki: %i[history diff annotate] },
-                      dependencies: :view_wiki_pages,
-                      permissible_on: :project
-
-      wiki.permission :edit_wiki_pages,
-                      { wiki: %i[edit update preview add_attachment new new_child create rename] },
-                      dependencies: :view_wiki_pages,
-                      permissible_on: :project
-
-      wiki.permission :manage_wiki,
-                      {
-                        wiki: %i[destroy protect edit_parent_page update_parent_page],
-                        wikis: %i[edit destroy],
-                        wiki_menu_items: %i[edit update select_main_menu_item replace_main_menu_item]
-                      },
-                      dependencies: :edit_wiki_pages,
-                      permissible_on: :project,
-                      require: :member
-    end
-
     map.project_module :repository do |repo|
       repo.permission :browse_repository,
                       { repositories: %i[show browse entry annotate changes diff stats graph] },

lib/redmine/menu_manager/wiki_menu_helper.rb

@@ -28,7 +28,7 @@
 
 module Redmine::MenuManager::WikiMenuHelper
   def build_wiki_menus(project)
-    return unless project.enabled_module_names.include? "wiki"
+    return unless Wikis::InternalProvider.enabled?
 
     project_wiki = project.wiki
     return if project_wiki.nil?

modules/boards/spec/features/onboarding/boards_onboarding_tour_spec.rb

@@ -55,10 +55,11 @@
 
   let(:demo_project) do
     create(:project,
+           :with_internal_wiki,
            name: "Demo project",
            identifier: "demo-project",
            public: true,
-           enabled_module_names: %w[work_package_tracking gantt wiki board_view])
+           enabled_module_names: %w[work_package_tracking gantt board_view]).reload
   end
   let!(:wp1) { create(:work_package, project: demo_project) }
 

modules/team_planner/spec/features/onboarding/team_planner_onboarding_tour_spec.rb

@@ -40,10 +40,11 @@
 
   let(:demo_project) do
     create(:project,
+           :with_internal_wiki,
            name: "Demo project",
            identifier: "demo-project",
            public: true,
-           enabled_module_names: %w[work_package_tracking gantt wiki team_planner_view])
+           enabled_module_names: %w[work_package_tracking gantt team_planner_view]).reload
   end
 
   let(:user) do

modules/wikis/app/models/wikis/internal_provider.rb

@@ -32,6 +32,10 @@ module Wikis
   class InternalProvider < Provider
     class << self
       def registry_prefix = "internal"
+
+      def enabled?
+        first&.enabled
+      end
     end
 
     def user_connected?(_user) = true

modules/wikis/lib/open_project/wikis/engine.rb

@@ -80,6 +80,32 @@ class Engine < ::Rails::Engine
     replace_principal_references "Wikis::PageLink" => %i[author_id]
 
     register "openproject-wikis", author_url: "https://openproject.org" do
+      project_module nil do
+        permission :view_wiki_pages,
+                   { wiki: %i[index show special menu export] },
+                   permissible_on: :project
+
+        permission :view_wiki_edits,
+                   { wiki: %i[history diff annotate] },
+                   dependencies: :view_wiki_pages,
+                   permissible_on: :project
+
+        permission :edit_wiki_pages,
+                   { wiki: %i[edit update preview add_attachment new new_child create rename] },
+                   dependencies: :view_wiki_pages,
+                   permissible_on: :project
+
+        permission :manage_wiki,
+                   {
+                     wiki: %i[destroy protect edit_parent_page update_parent_page],
+                     wikis: %i[edit destroy],
+                     wiki_menu_items: %i[edit update select_main_menu_item replace_main_menu_item]
+                   },
+                   dependencies: :edit_wiki_pages,
+                   permissible_on: :project,
+                   require: :member
+      end
+
       project_module :work_package_tracking do
         permission :manage_wiki_page_links,
                    {

modules/wikis/spec/services/wiki_pages/update_service_spec.rb

@@ -33,8 +33,8 @@
 RSpec.describe WikiPages::UpdateService do
   let(:instance) { described_class.new(user:, model: wiki_page) }
   let(:user) { create(:admin) }
-  let(:wiki_page) { create(:wiki_page) }
   let(:internal_provider) { create(:internal_wiki_provider, enabled: true) }
+  let(:wiki_page) { create(:wiki_page) }
 
   let(:work_package) { create(:work_package) }
 
@@ -52,9 +52,7 @@
 
   subject { instance.call(**attributes) }
 
-  before do
-    internal_provider
-  end
+  before { internal_provider }
 
   it "succeeds" do
     expect(subject).to be_success
@@ -227,7 +225,7 @@
   end
 
   describe "replacing the attachments" do
-    let(:project) { create(:project) }
+    let(:project) { create(:project, :with_internal_wiki).reload }
     let(:wiki_page) { create(:wiki_page, wiki: project.wiki, author: user) }
     let(:user) do
       create(:user,

spec/controllers/projects_settings_menu_controller_spec.rb

@@ -35,9 +35,9 @@
 
   let(:project) do
     # project contains wiki by default
-    create(:project, enabled_module_names: enabled_modules).tap(&:reload)
+    create(:project, :with_internal_wiki, enabled_module_names: enabled_modules).tap(&:reload)
   end
-  let(:enabled_modules) { %w[wiki] }
+  let(:enabled_modules) { %w[] }
   let(:params) { { project_id: project.id } }
 
   before do

spec/controllers/search_controller_spec.rb

@@ -32,19 +32,15 @@
 
 RSpec.describe SearchController do
   shared_let(:project) do
-    create(:project,
-           name: "eCookbook")
+    create(:project, :with_internal_wiki, name: "eCookbook").reload
   end
 
   shared_let(:other_project) do
-    create(:project,
-           name: "Other project")
+    create(:project, name: "Other project")
   end
 
   shared_let(:subproject) do
-    create(:project,
-           name: "Child project",
-           parent: project)
+    create(:project, name: "Child project", parent: project)
   end
 
   shared_let(:role) do

spec/controllers/wiki_controller_spec.rb

@@ -33,14 +33,10 @@
 RSpec.describe WikiController do
   shared_let(:admin) { create(:admin) }
 
-  shared_let(:project) do
-    create(:project).tap(&:reload)
-  end
+  shared_let(:project) { create(:project, :with_internal_wiki).reload }
   shared_let(:wiki) { project.wiki }
 
-  shared_let(:existing_page) do
-    create(:wiki_page, wiki_id: project.wiki.id, title: "ExistingPage", author: admin)
-  end
+  shared_let(:existing_page) { create(:wiki_page, wiki_id: wiki.id, title: "ExistingPage", author: admin) }
 
   describe "actions" do
     before do
@@ -968,9 +964,7 @@
   describe "view related stuff" do
     render_views
 
-    shared_let(:project) do
-      create(:public_project).tap(&:reload)
-    end
+    shared_let(:project) { create(:public_project, :with_internal_wiki).reload }
 
     # creating pages
     let!(:page_with_content) do

spec/controllers/wiki_menu_authentication_spec.rb

@@ -31,17 +31,13 @@
 require "spec_helper"
 
 RSpec.describe WikiMenuItemsController do
+  let(:project) { create(:project, :with_internal_wiki).reload }
+  let(:wiki_page) { create(:wiki_page, wiki: project.wiki) }
+  let(:params) { { project_id: project.id, id: wiki_page.title } }
+
   before do
     User.delete_all
     Role.delete_all
-
-    @project = create(:project)
-    @project.reload # project contains wiki by default
-
-    @params = {}
-    @params[:project_id] = @project.id
-    page = create(:wiki_page, wiki: @project.wiki)
-    @params[:id] = page.title
   end
 
   describe "w/ valid auth" do
@@ -50,9 +46,9 @@
 
       allow(User).to receive(:current).and_return admin_user
       permission_role = create(:project_role, name: "accessgranted", permissions: [:manage_wiki])
-      member = create(:member, principal: admin_user, user: admin_user, project: @project, roles: [permission_role])
+      create(:member, principal: admin_user, user: admin_user, project:, roles: [permission_role])
 
-      get "edit", params: @params
+      get("edit", params:)
 
       expect(response).to be_successful
     end
@@ -62,7 +58,7 @@
     it "be forbidden" do
       allow(User).to receive(:current).and_return create(:user)
 
-      get "edit", params: @params
+      get("edit", params:)
 
       expect(response).to have_http_status(:not_found)
     end

spec/controllers/wiki_menu_items_controller_spec.rb

@@ -34,7 +34,7 @@
   let(:current_user) { create(:admin) }
 
   # create project with wiki
-  let(:project) { create(:project).reload } # a wiki is created for project, but the object doesn't know of it (FIXME?)
+  let(:project) { create(:project, :with_internal_wiki).reload }
   let(:wiki) { project.wiki }
 
   let(:wiki_page) { create(:wiki_page, wiki:) } # first wiki page without child pages

spec/factories/workspace_factory.rb

@@ -91,5 +91,17 @@
     trait :template do
       templated { true }
     end
+
+    trait :with_internal_wiki do
+      transient do
+        start_page { "Wiki" }
+      end
+
+      callback(:after_create) do |workspace, evaluator|
+        create(:internal_wiki_provider) if Wikis::InternalProvider.none?
+
+        workspace.create_wiki(start_page: evaluator.start_page)
+      end
+    end
   end
 end

spec/features/activities/disabled_activity_spec.rb

@@ -34,10 +34,10 @@
   shared_let(:admin) { create(:admin) }
 
   let(:project1) do
-    create(:project, enabled_module_names: %i[work_package_tracking wiki])
+    create(:project, :with_internal_wiki, enabled_module_names: %i[work_package_tracking]).reload
   end
   let(:project2) do
-    create(:project, enabled_module_names: %i[work_package_tracking activity wiki])
+    create(:project, :with_internal_wiki, enabled_module_names: %i[work_package_tracking activity]).reload
   end
   let(:project3) do
     create(:project, enabled_module_names: %i[activity])
@@ -61,27 +61,27 @@
 
   current_user { admin }
 
-  it "does not display activities on projects disabling it" do
+  it "does not display activities on projects disabling it", skip: "Wiki activation has changed, needs an update" do
     visit activity_index_path
 
     check "Wiki"
     click_on "Apply"
 
     expect(page)
-      .to have_content(work_package2.subject)
+      .to have_text(work_package2.subject)
     expect(page)
-      .to have_content(wiki_page2.title)
+      .to have_text(wiki_page2.title)
 
     # Not displayed as activity is disabled
     expect(page)
-      .to have_no_content(work_package1.subject)
+      .to have_no_text(work_package1.subject)
     expect(page)
-      .to have_no_content(wiki_page1.title)
+      .to have_no_text(wiki_page1.title)
 
     # Not displayed as all modules except activity are disabled
     expect(page)
-      .to have_no_content(work_package3.subject)
+      .to have_no_text(work_package3.subject)
     expect(page)
-      .to have_no_content(wiki_page3.title)
+      .to have_no_text(wiki_page3.title)
   end
 end

spec/features/menu_items/wiki_menu_item_spec.rb

@@ -35,7 +35,7 @@
 
 RSpec.describe "Wiki menu items", :js do
   let(:user) { create(:user, member_with_permissions: { project => %i[view_wiki_pages manage_wiki] }) }
-  let(:project) { create(:project, enabled_module_names: %w[wiki]) }
+  let(:project) { create(:project, :with_internal_wiki).reload }
   let(:wiki) { project.wiki }
   let(:parent_menu) { wiki.wiki_menu_items.find_by(name: "wiki") }
   let(:wiki_page) { create(:wiki_page, wiki:) }
@@ -139,7 +139,7 @@
     end
 
     within "#menu-sidebar" do
-      expect(page).to have_no_content("Custom page name")
+      expect(page).to have_no_text("Custom page name")
     end
 
     # removing the menu item which is also the last wiki menu item

spec/features/onboarding/onboarding_tour_spec.rb

@@ -34,8 +34,8 @@
                :js, :selenium do
   let(:user) { create(:admin) }
   let(:project) do
-    create(:project, name: "Demo project", identifier: "demo-project", public: true,
-                     enabled_module_names: %w[work_package_tracking gantt wiki])
+    create(:project, :with_internal_wiki, name: "Demo project", identifier: "demo-project", public: true,
+                                          enabled_module_names: %w[work_package_tracking gantt]).reload
   end
 
   let!(:wp1) { create(:work_package, project:) }

spec/features/watching/toggle_watching_spec.rb

@@ -31,7 +31,7 @@
 require "spec_helper"
 
 RSpec.describe "Toggle watching", :js do
-  let(:project) { create(:project) }
+  let(:project) { create(:project, :with_internal_wiki).reload }
   let(:role) { create(:project_role, permissions: %i[view_messages view_wiki_pages]) }
   let(:user) { create(:user, member_with_roles: { project => role }) }
   let(:news) { create(:news, project:) }

spec/features/wiki/adding_editing_history_spec.rb

@@ -65,7 +65,7 @@
     login_as user
   end
 
-  it "adding, editing and history" do
+  it "adding, editing and history", skip: "Wiki activation changed, needs update" do
     visit project_settings_modules_path(project)
 
     expect(page).to have_no_css(".menu-sidebar .main-item-wrapper", text: "Wiki")

spec/features/wiki/attachment_upload_spec.rb

@@ -36,7 +36,7 @@
     create(:user,
            member_with_permissions: { project => %i[view_wiki_pages edit_wiki_pages] })
   end
-  let(:project) { create(:project) }
+  let(:project) { create(:project, :with_internal_wiki).reload }
   let(:attachments) { Components::Attachments.new }
   let(:image_fixture) { UploadedFile.load_from("spec/fixtures/files/image.png") }
   let(:editor) { Components::WysiwygEditor.new }
@@ -60,7 +60,7 @@
 
     expect_and_dismiss_flash(message: "Successful creation")
     expect(page).to have_css("#content img", count: 1)
-    expect(page).to have_content("Image uploaded the first time")
+    expect(page).to have_text("Image uploaded the first time")
     attachments_list.expect_attached("image.png")
 
     page.find_test_selector("wiki-edit-action-button").click
@@ -88,7 +88,7 @@
     expect(page).to have_text("Successful update")
     expect(page).to have_css("#content img", count: 2)
     # First figcaption is lost by having replaced the markdown
-    expect(page).to have_content("Image uploaded the second time")
+    expect(page).to have_text("Image uploaded the second time")
     attachments_list.expect_attached("image.png", count: 2)
 
     # Both images rendered referring to the api endpoint