Skip to content

Bug/STC-742: Fix column overflow in semantic ID autofix preview table #23514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akabiru merged 3 commits into from
Jun 3, 2026
Merged

Bug/STC-742: Fix column overflow in semantic ID autofix preview table #23514

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e6a4951
Render semantic ID autofix preview via BorderBoxTableComponent
akabiru Jun 2, 2026
23736a1
Add bottom spacing below the autofix preview table
akabiru Jun 2, 2026
284e62a
Switch to inline message component as the more conventional structure
akabiru Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 70 additions & 0 deletions app/components/work_packages/admin/settings/identifier_autofix_row_component.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,70 @@
# frozen_string_literal: true

#-- copyright
# OpenProject is an open source project management software.
# Copyright (C) the OpenProject GmbH
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License version 3.
#
# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
# Copyright (C) 2006-2013 Jean-Philippe Lang
# Copyright (C) 2010-2013 the ChiliProject Team
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
#
# See COPYRIGHT and LICENSE files for more details.
#++

module WorkPackages
module Admin
module Settings
class IdentifierAutofixRowComponent < OpPrimer::BorderBoxRowComponent
def project
render(Primer::Beta::Link.new(href: project_path(model[:project]))) { model[:project].name }
end

def previous_identifier
flex_layout(direction: :column) do |col|
col.with_row { render(Primer::Beta::Text.new) { model[:current_identifier] } }
if (label = error_label).present?
col.with_row do
render(Primer::Beta::Text.new(color: :danger, font_size: :small)) { label }
end
end
end
end

def autofixed_suggestion
model[:suggested_identifier]
end

# The sequence number is derived deterministically from the identifier so it looks
# varied across projects but is stable across renders. Range: 1–500.
def example_work_package_id
identifier = model[:suggested_identifier]
"#{identifier}-#{(identifier.bytes.sum % 500) + 1}"
end

private

def error_label
I18n.t("admin.settings.work_packages_identifier.autofix_preview.error_#{model[:error_reason]}",
default: "")
end
end
end
end
end
77 changes: 8 additions & 69 deletions app/components/work_packages/admin/settings/identifier_autofix_section_component.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,72 +38,11 @@
end
%>

<%=
render(border_box_container(mb: 3)) do |component|
component.with_header(font_weight: :bold) do
flex_layout do |header|
header.with_column(flex: 1) do
render(Primer::Beta::Text.new(font_weight: :semibold)) do
I18n.t("admin.settings.work_packages_identifier.box_header.label_project")
end
end
header.with_column(flex: 1) do
render(Primer::Beta::Text.new(font_weight: :semibold)) do
I18n.t("admin.settings.work_packages_identifier.box_header.label_previous_identifier")
end
end
header.with_column(flex: 1) do
render(Primer::Beta::Text.new(font_weight: :semibold)) do
I18n.t("admin.settings.work_packages_identifier.box_header.label_autofixed_suggestion")
end
end
header.with_column(flex: 1) do
render(Primer::Beta::Text.new(font_weight: :semibold)) do
I18n.t("admin.settings.work_packages_identifier.box_header.label_example_work_package_id")
end
end
end
end

displayed.each do |entry|
component.with_row do
flex_layout(align_items: :center) do |row|
row.with_column(flex: 1) do
render(Primer::Beta::Link.new(href: project_path(entry[:project]))) do
entry[:project].name
end
end
row.with_column(flex: 1) do
flex_layout(direction: :column) do |col|
col.with_row do
render(Primer::Beta::Text.new) { entry[:current_identifier] }
end
col.with_row do
render(Primer::Beta::Text.new(color: :danger, font_size: :small)) do
error_label(entry[:error_reason])
end
end
end
end
row.with_column(flex: 1) do
render(Primer::Beta::Text.new) { entry[:suggested_identifier] }
end
row.with_column(flex: 1) do
render(Primer::Beta::Text.new) { sample_wp_id(entry[:suggested_identifier]) }
end
end
end
end

if remaining_count.positive?
component.with_row do
render(Primer::Beta::Text.new(color: :muted)) do
I18n.t(
"admin.settings.work_packages_identifier.autofix_preview.remaining_projects",
count: remaining_count
)
end
end
end
end
%>
<%= render(Primer::Box.new(mb: 3)) do %>
<%= render(
WorkPackages::Admin::Settings::IdentifierAutofixTableComponent.new(
rows: displayed,
remaining_count:
)
) %>
<% end %>
15 changes: 0 additions & 15 deletions app/components/work_packages/admin/settings/identifier_autofix_section_component.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,6 @@ module WorkPackages
module Admin
module Settings
class IdentifierAutofixSectionComponent < ApplicationComponent
include OpPrimer::ComponentHelpers

DISPLAY_COUNT = ProjectIdentifiers::IdentifierAutofix::PreviewQuery::DISPLAY_COUNT

def initialize(projects_data:, total_count: projects_data.size)
Expand All @@ -46,19 +44,6 @@ def initialize(projects_data:, total_count: projects_data.size)
private

attr_reader :total_count, :displayed, :remaining_count

def error_label(error_reason)
I18n.t("admin.settings.work_packages_identifier.autofix_preview.error_#{error_reason}",
default: "")
end

# Produces a realistic-looking example work package ID for the preview table.
# The sequence number is derived deterministically from the identifier so it looks
# varied across projects but is stable across renders. Range: 1–500.
def sample_wp_id(identifier)
n = (identifier.bytes.sum % 500) + 1
"#{identifier}-#{n}"
end
end
end
end
Expand Down
80 changes: 80 additions & 0 deletions app/components/work_packages/admin/settings/identifier_autofix_table_component.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,80 @@
# frozen_string_literal: true

#-- copyright
# OpenProject is an open source project management software.
# Copyright (C) the OpenProject GmbH
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License version 3.
#
# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
# Copyright (C) 2006-2013 Jean-Philippe Lang
# Copyright (C) 2010-2013 the ChiliProject Team
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
#
# See COPYRIGHT and LICENSE files for more details.
#++

module WorkPackages
module Admin
module Settings
class IdentifierAutofixTableComponent < OpPrimer::BorderBoxTableComponent
columns :project, :previous_identifier, :autofixed_suggestion, :example_work_package_id
# Project and previous identifier hold the long content; spanning two grid columns lets
# them wrap instead of truncating, while the short handle columns stay compact.
main_column :project, :previous_identifier
mobile_labels :previous_identifier, :autofixed_suggestion, :example_work_package_id

def initialize(rows:, remaining_count: 0, **)
super(rows:, **)
@remaining_count = remaining_count
end

def row_class
IdentifierAutofixRowComponent
end

def mobile_title
header(:table_title)
end

def headers
[
[:project, { caption: header(:label_project) }],
[:previous_identifier, { caption: header(:label_previous_identifier) }],
[:autofixed_suggestion, { caption: header(:label_autofixed_suggestion) }],
[:example_work_package_id, { caption: header(:label_example_work_package_id) }]
]
end

def has_footer?
@remaining_count.positive?
end

def footer
I18n.t("admin.settings.work_packages_identifier.autofix_preview.remaining_projects",
count: @remaining_count)
end

private

def header(key)
I18n.t("admin.settings.work_packages_identifier.box_header.#{key}")
end
end
end
end
end
1 change: 1 addition & 0 deletions config/locales/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,6 +452,7 @@ en:
OpenProject can automatically update these so that they are valid as in the examples below.
Click on 'Convert identifiers' to update identifiers for all projects in this manner and enable project-based semantic identifiers.
box_header:
table_title: Projects with identifiers to update
label_project: Project
label_previous_identifier: Previous identifier
label_autofixed_suggestion: Future identifier
Expand Down
Loading