Skip to content

structure book issues - #507

Merged
elfkuzco merged 1 commit into
mainfrom
structure-book-issues
Sep 10, 2026
Merged

elfkuzco merged 1 commit into
mainfrom
structure-book-issues

Conversation

@elfkuzco

@elfkuzco elfkuzco commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Rationale

This PR enhances the issues detailed content by giving them a shape with details filled instead of generating the message on the backend. This allows the frontend to customize the message as they see fit

Changes

  • create types for several book issues with underlying models backed by Pydantic
  • create types for different issues in frontend
  • refactor logic to get different metadata keys to use two methods: get_book_metadata and get_book_title_metadata
  • render issues in different ways based on issue type
  • refactor logic to show metadata differences to use underlying issue information instead of computing it on frontend
Screenshot_20260908_135634 Screenshot_20260908_135409

This closes #480
This closes #475

@elfkuzco elfkuzco self-assigned this Sep 8, 2026
@elfkuzco
elfkuzco requested a review from benoit74 September 8, 2026 13:03
@codecov

codecov Bot commented Sep 8, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.81633% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.48%. Comparing base (fff640f) to head (8569905).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
backend/src/cms_backend/db/book.py 87.50% 4 Missing and 1 partial ⚠️
backend/src/cms_backend/schemas/models.py 92.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #507      +/-   ##
==========================================
+ Coverage   81.38%   81.48%   +0.10%     
==========================================
  Files          69       69              
  Lines        4308     4365      +57     
  Branches      509      511       +2     
==========================================
+ Hits         3506     3557      +51     
- Misses        640      645       +5     
- Partials      162      163       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread frontend/src/components/BookIssues.vue Outdated
Comment thread frontend/src/components/BookIssues.vue Outdated
Comment thread backend/src/cms_backend/db/book.py Outdated
Comment thread frontend/src/components/EntryCountIssueCard.vue Outdated
@elfkuzco
elfkuzco requested a review from benoit74 September 10, 2026 12:34

@benoit74 benoit74 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@elfkuzco
elfkuzco force-pushed the structure-book-issues branch from d7a8c80 to acd394d Compare September 10, 2026 12:42
@elfkuzco
elfkuzco force-pushed the structure-book-issues branch from acd394d to 8569905 Compare September 10, 2026 12:44
@elfkuzco
elfkuzco merged commit a2b2a8b into main Sep 10, 2026
7 checks passed
@elfkuzco
elfkuzco deleted the structure-book-issues branch September 10, 2026 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Recipe issue warning should display recipe names and link to Zimfarm Simplify media and article count alerts

2 participants