modemmanager: choose plugins for build#29898
Open
ckorber wants to merge 2 commits into
Open
Conversation
ckorber
force-pushed
the
pr/plugins_mm
branch
3 times, most recently
from
e8a72bf to
0c8b330
Compare
ckorber
force-pushed
the
pr/plugins_mm
branch
21 times, most recently
from
a6f454e to
27a08be
Compare
ckorber
force-pushed
the
pr/plugins_mm
branch
2 times, most recently
from
c1f2e81 to
fc965cd
Compare
ckorber
force-pushed
the
pr/plugins_mm
branch
6 times, most recently
from
98602fc to
52f61f8
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ckorber
force-pushed
the
pr/plugins_mm
branch
2 times, most recently
from
877739a to
60a993a
Compare
If modemmanager is integrated into slower devices, compiling all plugins may be too much. This prepares to choose the wanted plugins individually. Signed-off-by: Christian Korber <ckorber@tdt.de>
openwrt-ai
reviewed
Jul 9, 2026
openwrt-ai
left a comment
openwrt-ai
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed 1 new commit; no new issues found. The updated $(if $(CONFIG_MODEMMANAGER_WITH_MBIM),foxconn) / fibocom conditionals correctly replace the previously-flagged malformed @MODEMMANAGER_WITH_MBIM:... tokens and follow the existing $(if $(CONFIG_...),...) pattern used in MESON_ARGS.
Generated by Claude Code
ckorber
force-pushed
the
pr/plugins_mm
branch
4 times, most recently
from
8b6e223 to
f2bc069
Compare
This adds the feature to choose which plugins to include or not. Additionally, the needed shared plugins are added automatically. Signed-off-by: Christian Korber <ckorber@tdt.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📦 Package Details
Maintainer: @feckert
Description:
If modemmanager is integrated into slower devices, compiling all plugins
may be too much.
This adds the feature to choose which plugins to include or not.
Also it is possible to decide whether the plugins should be included into binary blob via
MODEMMANAGER_WITH_BUILTIN_PLUGINS.🧪 Run Testing Details
✅ Formalities