swgp-go: add at 1.10.0#29889
Conversation
| # swgp-go | ||
| This readme should help you configure swgp-go. | ||
|
|
||
| ## Configuration | ||
| Edit `/etc/swgp.json` with your desired configuration (Client, Server or both). | ||
|
|
||
| If you're configuring a server, also properly allow that port in your firewall. | ||
|
|
||
| Note the pprof feature is disabled in this package. If you try to enable it | ||
| regardless, `swgp-go` will show an error on startup. | ||
|
|
||
| ## Start daemon | ||
| Once you have created your config, enable and run swgp-go using its init script: | ||
|
|
||
| ``` | ||
| /etc/init.d/swgp-go enable | ||
| /etc/init.d/swpg-go start | ||
| ``` | ||
|
|
||
| Please refer to the [Project README](https://github.com/database64128/swgp-go) for more configuration info and examples. |
There was a problem hiding this comment.
Why do we need this readme? :-) How to start daemon it is quite obvious how OpenWrt works.
There was a problem hiding this comment.
Upstream doesn't have a canonical config file location, and as it requires some configuration on startup I wanted to write it down somewhere. And I saw some other packages also putting readme files like this in there. Is there a better location to put it, or you want me to remove it alltogether?
40b7487 to
a7179b8
Compare
|
Rebased and added a |
|
I got a notification from CI about a failing build just now, but this seems unrelated: @BKPepe anything left from my side here? |
openwrt-ai
left a comment
There was a problem hiding this comment.
Automated review of the new net/swgp-go package. Main items: two documentation errors in the README that would misdirect users (wrong config path and a swpg-go typo in the start command), plus a couple of minor Makefile/init nits. CI is still pending, so no build results to comment on.
Commit checks
Reviewed 1 new commit; message ("swgp-go: add at 1.10.0") matches the diff (new package addition), Signed-off-by present. No issues found.
Generated by Claude Code
|
|
||
| start_service() { | ||
| procd_open_instance | ||
| procd_set_param command $SWGP_GO_BIN -confPath $SWGP_GO_CONF -logLevel DEBUG |
There was a problem hiding this comment.
The log level is hard-coded to DEBUG, which is very verbose for a proxy that continuously handles traffic and will flood the system log by default. Was that intentional, or should this be a saner default such as info (optionally made configurable via UCI)?
Generated by Claude Code
There was a problem hiding this comment.
It doesn't log for each packet, but logs two more lines once a new session is established. There isn't any uci config integration so far, and logging for sessions is also something dropbear does, so I'd say it's ok to keep it that way for now.
50cadf8 to
2a96be0
Compare
openwrt-ai
left a comment
There was a problem hiding this comment.
Re-reviewed after the earlier feedback was addressed (the commit was amended). Verified the fixes against the current tree:
- README config path is now
/etc/swgp-go.json, consistent with the Makefileconffiles/installrule andSWGP_GO_CONFin the init script. - README start-command typo
swpg-go→swgp-gocorrected. - Makefile
TITLE:=/URL:=leading space removed. - Empty
$(1)/etc/configdropped from theINSTALL_DIRline.
The -logLevel DEBUG question was answered (logging only occurs on session establishment, comparable to dropbear) — no objection to keeping it.
Reviewed 1 amended commit ("swgp-go: add at 1.10.0"); message still matches the diff and Signed-off-by is present. No new issues found.
Generated by Claude Code
|
Erf, seems there's a |
c7ef391 to
d9400d2
Compare
openwrt-ai
left a comment
There was a problem hiding this comment.
Re-reviewed the one new change since the last review (the amended commit updated only net/swgp-go/test.sh). All previously-raised items were addressed. One minor note on the test script's exit-status handling inline. The commit message ("swgp-go: add at 1.10.0") still matches the diff and Signed-off-by is present. CI is still pending, so no build results to comment on.
Generated by Claude Code
Compiled on x86_64-linux, successfully tested on mediatek/filogic, 25.12.5. Signed-off-by: Florian Klink <flokli@flokli.de>
openwrt-ai
left a comment
There was a problem hiding this comment.
Re-reviewed the one new change since the last review: the amended commit updated only net/swgp-go/test.sh. My earlier exit-status note is addressed — the version check ($2) now gates the exit via an explicit exit 1 on mismatch, and the package-name ($1) check was intentionally dropped.
Commit checks
- Reviewed 1 amended commit (
swgp-go: add at 1.10.0); message still matches the diff (new package addition), Signed-off-by present. - No new issues. The
[ $? == 0 ]construct is fine here: these test scripts run under busybox ash (per theshellcheck shell=busyboxconvention in CONTRIBUTING.md), whosetest/[accepts==, and this mirrors the existing in-treenet/tcpreplay/test.sh.
CI is still pending, so no build results to comment on.
Generated by Claude Code
Compiled on x86_64-linux, successfully tested on mediatek/filogic, 25.12.5.
📦 Package Details
Maintainer: @flokli (me)
Description:
This acts as a proxy for wireguard connections, providing some levels of obfuscation on top.
🧪 Run Testing Details
✅ Formalities
If your PR contains a patch:
git am(e.g., subject line, commit description, etc.)
We must try to upstream patches to reduce maintenance burden.