samba4: bump to 4.24.3#29877
Conversation
|
Hmm tests failed with the following errors : I am not sure on how to continue with that vague errors. |
libpam is samba4-libs's conditional dependency and requires version check overrides, I can add it if you don't know how to. |
|
Yes I have understood it's conditional dependency, please do, so co-authored ? [EDIT] |
|
Here you go Yang-Wei-Ting@4ca5b9c |
|
Ah thanks, will try to include it along in here. I hope it will get approve. |
|
Need someone to run testing this PR, especially on x86_64 |
|
Run tested runs well, tested with transferring file :
glibc |
openwrt-ai
left a comment
openwrt-ai
left a comment
There was a problem hiding this comment.
Commit checks
cfa2e1e(samba4: bump to 4.24.3): the diff carries two functional changes not covered by the commit message — the new/enabled SMB security settings infiles/smb.conf.template(client ipc min protocol,smb encrypt,server signing,client/server smb encrypt) and the removal of theNONE,prefix from--bundled-librariesin theMakefile. Please either document these in the message or split them out; a version-bump commit should ideally be limited to the mechanics of the bump. See inline comments.b806b43(libpam: add version check override): message matches the diff; the addedtest-version.shfollows the in-tree convention (libseccomp/expat). No issues.
Two dimensions (patch header refresh to git am format, cross-arch geting→getting typo fixes) look correct.
Generated by Claude Code
https://www.samba.org/samba/history/samba-4.24.3.html Removed due to fixed in Makefile: 012-fix-gnutls-version-check.patch Makefile: Fixed gnutls sed related things Fixed compile_et & asn1_compile linkage at build time to fixes build error Dropped NONE from bundled-libraries as to fix compilation errors, NONE now seems meaning not to bundle any libraries. smb.conf.template: Added SMB2 as default minimum protocol for client, also enabled server & client encryption by default. Use smbpasswd -a username to add a username & password for samba. To connect into samba from Windows 10 and above, it need to be done by this guide : https://www.asus.com/support/faq/1054736/ . Build system: x86/64 Build-tested: x86/64 Run-tested: x86/64-glibc Signed-off-by: Aditya Nugraha <vortexilation@gmail.com>
The libpam helper executables do not report the package version, causing the generic version probe to fail. Add a package-specific test-version.sh to skip the version check. Co-authored-by: Wei-Ting Yang <williamatcg@gmail.com> Signed-off-by: Aditya Nugraha <vortexilation@gmail.com>
openwrt-ai
left a comment
openwrt-ai
left a comment
There was a problem hiding this comment.
Reviewed the changes since my last review (b806b43). The branch was rebased onto current master; the only change to this PR's own files is a trailing-whitespace cleanup on the blank line in net/samba4/files/smb.conf.template, and the samba4: bump to 4.24.3 commit message was expanded to document the smb.conf.template SMB security settings and the Dropped NONE from bundled-libraries change — which resolves the commit-check point from my previous review. No new issues found.
Generated by Claude Code
4 participants
https://www.samba.org/samba/history/samba-4.24.3.html
Removed due to fixed in Makefile:
012-fix-gnutls-version-check.patch
Makefile:
Fixed gnutls sed related things
Fixed compile_et & asn1_compile linkage at build time to fixes build error
Build system: x86/64 musl
Build-tested: x86/64 musl
Build system: x86/64 glibc
Build-tested: x86/64 glibc
Run-tested: x86/64 glibc
📦 Package Details
Description:
Bump into samba version 4.24.3
🧪 Run Testing Details
glibc
✅ Formalities
If your PR contains a patch:
git am(e.g., subject line, commit description, etc.)
We must try to upstream patches to reduce maintenance burden.