Skip to content

qemu: Enable QEMU package support in .config for Rockchip devices#26797

Open
davidandreoletti wants to merge 1 commit into
openwrt:masterfrom
davidandreoletti:davidandreoletti-qemu-rockchip-support
Open

qemu: Enable QEMU package support in .config for Rockchip devices#26797
davidandreoletti wants to merge 1 commit into
openwrt:masterfrom
davidandreoletti:davidandreoletti-qemu-rockchip-support

Conversation

@davidandreoletti

@davidandreoletti davidandreoletti commented Jun 19, 2025

Copy link
Copy Markdown
Contributor

📦 Package Details

Maintainer:
@yousong

Description:
OpenWrt's .config now support declaring qemu-* packages as part of the Rockchip devices OpenWRT images.


🧪 Run Testing Details

  • OpenWrt Version: SNAPSHOTS
  • OpenWrt Target/Subtarget: rockchip
  • OpenWrt Device: NanoPi R4s

✅ Formalities

  • I have reviewed the CONTRIBUTING.md file for detailed contributing guidelines.

@davidandreoletti

davidandreoletti commented Jun 24, 2025

Copy link
Copy Markdown
Contributor Author

@yousong Unclear to me if mipsel / riscv64 issues are related to PR changes or long standing issues with OpenWRT build system. Would you mind reviewing the PR please ?

@BKPepe

BKPepe commented Jun 30, 2025

Copy link
Copy Markdown
Member

Nitpick: Its OpenWrt not OpenWRT

@davidandreoletti

Copy link
Copy Markdown
Contributor Author

@BKPepe Got it!

@davidandreoletti davidandreoletti force-pushed the davidandreoletti-qemu-rockchip-support branch from 34b80a9 to 3cb9aa2 Compare September 4, 2025 05:40
@davidandreoletti davidandreoletti force-pushed the davidandreoletti-qemu-rockchip-support branch from 3cb9aa2 to 76a56cc Compare September 23, 2025 08:23
@BKPepe BKPepe force-pushed the davidandreoletti-qemu-rockchip-support branch from 76a56cc to f0687aa Compare July 5, 2026 09:29
@davidandreoletti davidandreoletti force-pushed the davidandreoletti-qemu-rockchip-support branch from f0687aa to 26f4da7 Compare July 6, 2026 11:28
@davidandreoletti davidandreoletti force-pushed the davidandreoletti-qemu-rockchip-support branch from 26f4da7 to 3d61671 Compare July 6, 2026 11:38

@openwrt-ai openwrt-ai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 new commit.

The functional change is correct: adding TARGET_rockchip to QEMU_DEPS_IN_HOST enables the host-side QEMU packages (qemu-img / qemu-nbd / qemu-system-* / firmware / keymaps) for the arm64 rockchip target, consistent with the existing armsr_armv8 and sunxi entries. The PKG_RELEASE bump 2 -> 3 is appropriate. All 14 CI checks are green.

Commit checks

  • nit: The commit subject rockchip: enable qemu package support in .config for Rockchip devices uses a target name as the prefix. In openwrt/packages the convention is <package>: <change>; since this commit only modifies utils/qemu/Makefile, qemu: would be the expected prefix.

Generated by Claude Code

OpenWRT's .config support declaring qemu-* packages as part of the
Rockchip devices OpenWRT images.

Maintainer: @yousong
Compile tested: snapshot
Run tested: NanoPi R4S

Signed-off-by: David Andreoletti <david.andreoletti.dev@gmail.com>
@davidandreoletti davidandreoletti force-pushed the davidandreoletti-qemu-rockchip-support branch from 3d61671 to 17cf08b Compare July 9, 2026 12:34
@davidandreoletti davidandreoletti changed the title rockchip: Enable QEMU package support in .config for Rockchip devices qemu: Enable QEMU package support in .config for Rockchip devices Jul 9, 2026
@davidandreoletti

Copy link
Copy Markdown
Contributor Author

@yousong Would you like to review this PR ? The build log fails only for the i386 target due to a checksum mismatch in the openwrt sdk downloaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants