⬆️ Move the FHIR commons utils dependency to the plugin and re-enable the spotless plugin#13
Conversation
…the spotless plugin
| <version>1.18.24</version> | ||
| </dependency> | ||
|
|
||
| <dependency> |
There was a problem hiding this comment.
Have you added this in the plugins module?
@dubdabasoduba
There was a problem hiding this comment.
Yes, it was already available. So I don't think the server needed it.
There was a problem hiding this comment.
Right, that makes sense.
Let me test the PR first and then we can merge.
There was a problem hiding this comment.
I have tested the PR, we have to include this as a dependency in the server module because it fails with ClassNotFoundException.
@dubdabasoduba
There was a problem hiding this comment.
This is interesting, we want to abstract all the OpenSRP-related work from the server. We do not want to update the server just for the OpenSRP use case. I think we need to review how we have written to code to decouple this requirement.
2 participants
Description of what I changed
E2E test
TESTED:
Please replace this with a description of how you tested your PR beyond the
automated e2e/unit tests.
Checklist: I completed these to help reviewers :)
I have read and will follow the
review process.
I am familiar with Google Style Guides for the language I have coded in.
No? Please take some time and review
Java and
Python style guides. Note,
when in conflict, OpenMRS style guide overrules.
My IDE is configured to follow the Google
code styles.
No? Unsure? ->
configure your IDE.
I have added tests to cover my changes. (If you refactored existing
code that was well tested you do not have to add tests)
I ran
mvn clean packageright before creating this pull request andadded all formatting changes to my commit.
All new and existing tests passed.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master