OCM-00000 | ci: Update openshift-ocm to v0.0.462 - #3420
Conversation
Signed-off-by: red-hat-konflux-kflux-prd-rh02 <190377777+red-hat-konflux-kflux-prd-rh02[bot]@users.noreply.github.com>
red-hat-konflux-kflux-prd-rh02
Bot
added
the
ok-to-test
|
Hi @red-hat-konflux-kflux-prd-rh02[bot]. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@red-hat-konflux-kflux-prd-rh02: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@coderabbitai check if there is anything that we should change in the cli (or it could be improved) due |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
echo '=== PR diff and dependency references ==='
git diff -- go.mod go.sum || true
rg -n -i -C 3 'SpotMarketOptions|spot.market|spot[-_ ]instance|spot[-_ ]market|machine.?pool|MachinePool' \
-g '*.go' -g 'go.mod' -g 'go.sum' .
echo
echo '=== Likely CLI structure ==='
fd -t f -e go . | rg -i '(machine.?pool|cluster|hcp|node.?pool|create|edit)' | head -250
echo
echo '=== v0.0.462 module cache references, if available ==='
moddir="$(go env GOPATH 2>/dev/null)/pkg/mod/github.com/openshift-online/ocm-api-model/clientapi@v0.0.462"
if [ -d "$moddir" ]; then
rg -n -i -C 3 'SpotMarketOptions|spot.market|spot[-_ ]instance' "$moddir"
else
echo "Module cache directory unavailable: $moddir"
fiLength of output: 165463 🏁 Script executed: #!/bin/bash
set -euo pipefail
echo '=== Dependency update in this PR ==='
git diff --unified=80 "$(git merge-base HEAD origin/master 2>/dev/null || git merge-base HEAD master 2>/dev/null || true)" -- go.mod go.sum 2>/dev/null || \
git diff --unified=80 -- go.mod go.sum
echo
echo '=== Relevant implementation outlines ==='
ast-grep outline pkg/machinepool/machinepool.go --items all
ast-grep outline pkg/ocm/nodepools.go --items all
ast-grep outline pkg/options/machinepool/create.go --items all
echo
echo '=== HCP and classic request construction / spot option consumption ==='
rg -n -i -C 12 \
'UseSpotInstances|SpotMaxPrice|SpotMarketOptions|AWSSpotMarketOptions|AWSNodePool|NewNodePool|CreateNodePool|CreateMachinePool' \
pkg/machinepool pkg/ocm cmd/create/machinepool pkg/options/machinepool \
-g '*.go'
echo
echo '=== Focused unit-test coverage ==='
rg -n -i -C 8 \
'UseSpotInstances|SpotMaxPrice|SpotMarketOptions|AWSNodePool|NewNodePool|CreateNodePool' \
pkg/machinepool cmd/create/machinepool pkg/options/machinepool \
-g '*_test.go'
echo
echo '=== Upstream release metadata and source comparison ==='
gh api 'repos/openshift-online/ocm-api-model/compare/v0.0.461...v0.0.462' \
--jq '.files[] | select(.filename|test("clusters_mgmt|node_pool|aws"; "i")) | {filename,status,patch}' \
2>/dev/null || true
gh api 'repos/openshift-online/ocm-api-model/releases/tags/v0.0.462' \
--jq '{tag_name,name,body}' 2>/dev/null || trueLength of output: 201986 🏁 Script executed: #!/bin/bash
set -euo pipefail
echo '=== HCP AWS node-pool builder and its caller ==='
rg -n -C 35 \
'func createAwsNodePoolBuilder|createAwsNodePoolBuilder\(|func \(.*\) CreateNodePools|func \(.*\) CreateMachinePool|SpotMarketOptions' \
pkg/machinepool/helper.go pkg/machinepool/machinepool.go
echo
echo '=== Classic spot request builder for semantic parity ==='
rg -n -C 30 \
'UseSpotInstances|SpotMaxPrice|AWSSpotMarketOptions|SpotMarketOptions' \
pkg/machinepool/helper.go pkg/machinepool/machinepool.go
echo
echo '=== HCP POST-body assertions and nearby successful-create setup ==='
sed -n '1715,1860p' pkg/machinepool/machinepool_test.go
echo
echo '=== Termination-handler / SQS queue support in current CLI ==='
rg -n -i -C 6 \
'termination.?handler|termination_handler|queue.?url|queue_url|node.?termination|SQS' \
-g '*.go' -g '*.md' -g '*.adoc' .
echo
echo '=== Direct dependency version lines ==='
rg -n -C 2 'openshift-online/ocm-api-model/clientapi|openshift-online/ocm-sdk-go' go.mod go.sumLength of output: 42514
The CLI already accepts Recommended CLI changeUpdate the HCP node-pool creation path to:
The helper in The release also introduces |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amandahla, red-hat-konflux-kflux-prd-rh02[bot] The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
1 participant
This PR contains the following updates:
v0.0.461→v0.0.462Release Notes
openshift-online/ocm-api-model (github.com/openshift-online/ocm-api-model/clientapi)
v0.0.462: Release 0.0.462Compare Source
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.