ROSAENG-61450 | chore: bump go.mod to 1.26.5#3388
Conversation
Follow-up to openshift#3366: align go.mod, bingo tool modules, and renovate Go constraint with ubi9/go-toolset 1.26.5 already used by Dockerfiles. Drop deferred stdlib Snyk and govulncheck ignores fixed in Go >= 1.26.4. Depends on openshift/release#81830 (from: rosa-clients) so Prow presubmits compile with go-toolset 1.26.5 instead of ocp/builder 1.26.3. Signed-off-by: Amanda Hager Lopes de Andrade Katz <amanda.katz@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: Amanda Hager Lopes de Andrade Katz <amanda.katz@redhat.com>
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amandahla The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (11)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughUpdated the main Go module, seven Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PR Summary
Bump
go.mod(and related pins) to Go 1.26.5 as the follow-up to #3366. Also drops deferred stdlib Snyk/govulncheck ignores fixed in Go >= 1.26.4.Depends on: openshift/release#81830 (
from: rosa-clients). Do not merge this until that release PR is in, or Prow may fail withgo.mod requires go >= 1.26.5 (running go 1.26.3; GOTOOLCHAIN=local).Also covers / supersedes: #3382 (Darkstar stdlib CVE bump to 1.26.4) — 1.26.5 includes those fixes.
Detailed Description of the Issue
#3366 aligned Dockerfiles on
ubi9/go-toolset:1.26.5but leftgo.modat 1.26.3 so existingfrom: srcjobs kept passing. After release wiresrosa-clients,go.modcan move to 1.26.5.Related Issues and PRs
Type of Change
Previous Behavior
go.mod/ bingo / renovate Go constraint at 1.26.3; stdlib Snyk and govulncheck ignores deferred until Go >= 1.26.4. Dockerfiles already on go-toolset 1.26.5 from #3366.Behavior After This Change
go.mod→1.26.5.bingo/*.mod→1.26.5renovate.jsongomod.constraints.go→1.26.5.snykand.govulncheck-ignore.yaml.ci-operator.yamlunchanged (already 1.26.x from ROSAENG-61450 | ci: add presubmit client image and go-toolset 1.26.5 #3366)How to Test (Step-by-Step)
Preconditions
mise exec go@1.26.5 -- …)Test Steps
mise exec go@1.26.5 -- bash -lc 'export GOTOOLCHAIN=auto && make fmt-check && make rosa && make lint && make test'podman build -f Dockerfile.clients -t rosa-clients:local .then no-mountmake rosaExpected Results
Local checks pass; after release PR, Prow
build/lint/testpass on go-toolset 1.26.5.Proof of the Fix
fmt-check,rosa,lint,testpassed on Go 1.26.5coderabbit --agent -t uncommitted): 0 findingsgovulnchecksource scan clean; binary still reports pre-existingGO-2026-5932ingolang.org/x/crypto(no fix available)Breaking Changes
Developer Verification Checklist
[JIRA-TICKET] | [TYPE]: <MESSAGE>.make install-hookshas been run in this clone.make testpasses.make lintpasses.make rosapasses.Made with Cursor
Summary by CodeRabbit