Skip to content

quay: publish Playwright runner images#82052

Open
jbpratt wants to merge 1 commit into
openshift:mainfrom
jbpratt:quay-playwright-runner-promotion
Open

quay: publish Playwright runner images#82052
jbpratt wants to merge 1 commit into
openshift:mainfrom
jbpratt:quay-playwright-runner-promotion

Conversation

@jbpratt

@jbpratt jbpratt commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Summary

  • build quay-playwright-runner from the repository-owned web/playwright/Dockerfile instead of an inline Dockerfile
  • promote both quay-server and quay-playwright-runner to the quay integration namespace as latest and immutable commit tags after master merges
  • regenerate the Quay presubmit and promotion postsubmit jobs with both Dockerfile paths in sparse checkout

Dependency

Merge quay/quay#6553 first. This configuration references the Dockerfile introduced by that PR, so this dependent release PR must not merge before the Quay source change.

Validation

  • make ci-operator-config SKIP_PULL=true
  • make jobs WHAT=quay/quay SKIP_PULL=true (includes ci-operator checkconfig)
  • targeted ci-operator check of ci-operator/config/quay/quay
  • targeted Prow checkconfig of generated quay/quay jobs
  • git diff --check

Full make checkconfig was also attempted from the relocated on-disk worktree. The local Podman run reached the Prow scanner but failed while walking the repository mount with stat /release/core-services/prow/02_config: invalid argument; the targeted job validation passes.

Summary by CodeRabbit

  • Updates Quay image CI to build quay-playwright-runner from the repository-owned web/playwright/Dockerfile.
  • Promotes both quay-server and quay-playwright-runner to the quay integration namespace after master merges, using latest and immutable commit-based tags.
  • Regenerates Quay presubmit and promotion postsubmit jobs so sparse checkouts include both Dockerfile paths.
  • Validation included targeted CI configuration checks, Prow checks, git diff --check, and successful configuration generation. Full make checkconfig was blocked by a local Podman repository-mount error.
  • Depends on quay/quay#6553 merging first.

Build the Playwright runner from its repository-owned Dockerfile and regenerate the Quay image jobs with both Dockerfile paths in sparse checkout.

Promote the Quay server and Playwright runner after master merges using both the moving latest tag and immutable commit tags.
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: c15b1f53-307d-4da4-9a3e-59271cbe3abe

📥 Commits

Reviewing files that changed from the base of the PR and between 64f6a96 and 2a7a0e8.

⛔ Files ignored due to path filters (2)
  • ci-operator/jobs/quay/quay/quay-quay-master-postsubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/quay/quay/quay-quay-master-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/quay/quay/quay-quay-master.yaml

Walkthrough

The Playwright runner image configuration now builds from web/playwright/Dockerfile and promotes the resulting image to the quay namespace with latest and commit-derived tags.

Changes

Playwright image pipeline

Layer / File(s) Summary
Build and promotion configuration
ci-operator/config/quay/quay/quay-quay-master.yaml
The Playwright runner build uses an external Dockerfile while retaining its source and destination, and promotion adds the latest tag plus commit-derived tagging.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: publishing the Quay Playwright runner image.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The commit only changes ci-operator/job YAML; no It/Describe/Context/When test titles were added or modified.
Test Structure And Quality ✅ Passed PR changes only ci-operator/job YAML; no Go/Ginkgo test files were modified, so the test-quality checklist is not applicable.
Microshift Test Compatibility ✅ Passed PR only changes ci-operator/job YAML for Quay images; no Ginkgo e2e tests or OpenShift API/resource usage were added or modified.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only ci-operator config and generated job YAML changed; no new or modified Ginkgo tests, so SNO compatibility is not implicated.
Topology-Aware Scheduling Compatibility ✅ Passed Only ci-operator config and generated Prow jobs changed; no deployment manifests, controllers, or scheduling fields were added or modified.
Ote Binary Stdout Contract ✅ Passed Only ci-operator/job YAML changed; no process-level code or stdout-writing binary setup was introduced.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The PR only changes ci-operator/job YAML; no .go or Ginkgo e2e tests were added or edited, so no IPv4 or external-network assumptions were introduced.
No-Weak-Crypto ✅ Passed Diff only updates ci-operator YAML/job generation; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparisons found.
Container-Privileges ✅ Passed Changed Quay config and generated jobs contain no privileged, hostPID/hostNetwork/hostIPC, allowPrivilegeEscalation, SYS_ADMIN, or explicit root settings.
No-Sensitive-Data-In-Logs ✅ Passed Changed files are CI config/job YAML; scan found only secret references and internal paths, with no literal passwords/tokens/PII or log statements.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from Marcusk19 and Sunandadadi July 17, 2026 00:38
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2026
@openshift-ci

openshift-ci Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

@jbpratt: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2026
@openshift-ci

openshift-ci Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jbpratt, LiZhang19817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants