Fix Cluster Autoscaler tests in Cluster API Actuator repo

[joelsmith]

Strangely, the existing e2e-aws-autoscaler was actually a periodic pre.

• Rename old e2e-aws-autoscaler to e2e-aws-autoscaler-periodic-pre
• Add new e2e-aws-autoscaler-periodic to run non-periodics

Summary by CodeRabbit

Updates OpenShift CI configuration for the cluster-api-actuator-pkg AWS autoscaler E2E tests by splitting coverage into three distinct job targets:

• Renames the existing optional autoscaler “periodic” coverage to e2e-aws-autoscaler-periodic-pre, and makes it run only when autoscaler-related Go code changes (cluster-autoscaler-operator.go or pkg/autoscaler/). This job executes make test-e2e-periodic-autoscaler.
• Adds a new scheduled job e2e-aws-autoscaler-periodic (72h cadence) for periodic AWS autoscaler validation.
• Introduces/updates the non-periodic e2e-aws-autoscaler job with the same autoscaler-change gating as the pre-job, running make test-e2e-autoscaler.

Related job wiring is updated in the autoscale test job definitions to ensure the periodic target is available to presubmit /test commands and reruns.

[coderabbitai]

Warning

Review limit reached

@joelsmith, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 3 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: dc1aeac4-10f6-440e-9bb2-f67a2280ca2e

📥 Commits

Reviewing files that changed from the base of the PR and between f835b41 and 8c541f3.

⛔ Files ignored due to path filters (1)

• ci-operator/jobs/openshift/cluster-api-actuator-pkg/openshift-cluster-api-actuator-pkg-master-presubmits.yaml is excluded by !ci-operator/jobs/**

📒 Files selected for processing (1)

• ci-operator/config/openshift/cluster-api-actuator-pkg/openshift-cluster-api-actuator-pkg-master.yaml

Walkthrough

The AWS autoscaler CI configuration adds an optional pre job, gates autoscaler jobs on relevant Go paths, and changes the existing job to run the standard autoscaler E2E target.

Changes

AWS autoscaler CI workflow

Layer / File(s)	Summary
Autoscaler job gating and execution ci-operator/config/openshift/cluster-api-actuator-pkg/openshift-cluster-api-actuator-pkg-master.yaml	Adds the optional e2e-aws-autoscaler-periodic-pre job, applies run_if_changed gating to both autoscaler jobs, and changes the existing job to run make test-e2e-autoscaler.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: mdbooth, theobarberbany

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title is related and gives a clear high-level summary of the autoscaler test changes in the Cluster API Actuator repo.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	Only CI job config changed; no Ginkgo test titles were added or modified, so there are no dynamic test names to flag.
Test Structure And Quality	✅ Passed	Only ci-operator YAML changed; no Ginkgo test code was added or modified, so the test-quality check is not applicable.
Microshift Test Compatibility	✅ Passed	Only CI job YAML changed; no new Ginkgo e2e test definitions were added, so no MicroShift-incompatible APIs to review.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	Only a ci-operator YAML changed; no Ginkgo e2e tests were added or modified, so SNO compatibility review is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	Only ci-operator test job config changed; no deployment manifests, controllers, replicas, affinity, or node selectors were modified.
Ote Binary Stdout Contract	✅ Passed	PR only changes a ci-operator YAML job config; no OTE binary code, main/init/TestMain, or suite setup stdout writes were introduced.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR only changes ci-operator YAML job wiring; no Go/Ginkgo test bodies were added or modified, so there’s nothing to flag for IPv4 or external connectivity.
No-Weak-Crypto	✅ Passed	Touched YAML only renames/autoscaler test jobs; scans found no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB or custom crypto usage.
Container-Privileges	✅ Passed	Only the CI job config changed; it contains no privileged, hostPID/Network/IPC, SYS_ADMIN, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs	✅ Passed	The diff only renames/repoints CI jobs and changes test commands; it adds no logging or sensitive values.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-merge-bot]

@joelsmith, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not load configuration from candidate revision of release repo: failed to load ci-operator configuration from release repo: invalid ci-operator config: invalid configuration: tests[22]: `cron`/`interval`/`minimum_interval` are mutually exclusive with `run_if_changed`/`skip_if_only_changed`/`optional`

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[maxcao13]

/lgtm

Thanks!

[joelsmith]

/pj-rehearse list

[openshift-merge-bot]

@joelsmith: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[joelsmith]

/pj-rehearse list

Let's try again. Maybe I put it in a bad state with my first broken commit and it won't recover.

[openshift-merge-bot]

@joelsmith: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@joelsmith: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[maxcao13]

/lgtm

[elmiko]

Strangely, the existing e2e-aws-autoscaler was actually a periodic pre.

that was intentional. for reference, #80669

/approve
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko, joelsmith, maxcao13

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/cluster-api-actuator-pkg/OWNERS [elmiko]
• ci-operator/jobs/openshift/cluster-api-actuator-pkg/OWNERS [elmiko]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment