Skip to content

fleetshift: add periodic multiarch mirror for Dockerfile.fleetshift#82045

Merged
openshift-merge-bot[bot] merged 2 commits into
openshift:mainfrom
alechenninger:fleetshift-periodic-dockerfile-fleetshift
Jul 17, 2026
Merged

fleetshift: add periodic multiarch mirror for Dockerfile.fleetshift#82045
openshift-merge-bot[bot] merged 2 commits into
openshift:mainfrom
alechenninger:fleetshift-periodic-dockerfile-fleetshift

Conversation

@alechenninger

@alechenninger alechenninger commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add a dedicated fleetshift CI variant that periodically builds multiarch Dockerfile.fleetshift and mirrors it to quay.io/stolostron/fleetshift:latest
  • Reuse the same retry / staggered-cron pattern as the existing republish-latest jobs from fleetshift: harden image mirror CI against build-farm flakes #82029
  • Keep this separate from main so existing PR and postsubmit jobs are unchanged (only an optional fleetshift-images context is added)

Test plan

  • make ci-operator-config / make jobs regenerates cleanly
  • Confirm generated periodic targets only Dockerfile.fleetshift
  • Confirm existing main presubmits/postsubmits are unmodified aside from the additive optional fleetshift-images job
  • After merge, verify the periodic builds and publishes :latest once Dockerfile.fleetshift exists upstream

Made with Cursor

Summary by CodeRabbit

  • Adds a dedicated Fleetshift CI variant for the fleetshift-poc repository.
  • Periodically builds the multi-architecture Dockerfile.fleetshift image and mirrors it to quay.io/stolostron/fleetshift:latest.
  • Restricts the image job to changes affecting Dockerfile.fleetshift, while preserving existing PR and postsubmit workflows.

Introduce a dedicated fleetshift variant that builds and republishes
quay.io/stolostron/fleetshift:latest on a staggered cron with retries,
without changing existing main PR or postsubmit jobs.

Co-authored-by: Cursor <cursoragent@cursor.com>
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2026
@openshift-ci
openshift-ci Bot requested review from Hyperkid123 and mshort55 July 16, 2026 20:33
…nges

Replace image-level optional with images.run_if_changed so the variant
images job does not schedule on every PR.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

Adds a Fleetshift POC CI configuration that builds the image from Dockerfile.fleetshift and schedules arm64 republishing to the stolostron registry.

Changes

Fleetshift CI

Layer / File(s) Summary
Fleetshift image build configuration
ci-operator/config/fleetshift/fleetshift-poc/...fleetshift.yaml
Configures the Go 1.25 builder, Fleetshift Dockerfile, arm64 architecture, rebuild trigger, and default resource requests.
Scheduled image republish workflow
ci-operator/config/fleetshift/fleetshift-poc/...fleetshift.yaml
Adds scheduled republish-latest execution, retry settings, image mirror environment variables, workflow naming, and generated metadata.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: hyperkid123, mshort55

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: adding a periodic multi-arch mirror for Dockerfile.fleetshift.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR only changes ci-operator YAML; no Ginkgo specs or test titles were added or modified, so the rule isn't implicated.
Test Structure And Quality ✅ Passed PASS: The PR only changes ci-operator YAML configs; no Ginkgo test files or test code are added or modified, so this check is not applicable.
Microshift Test Compatibility ✅ Passed No Ginkgo/e2e test code was added; the PR only changes CI config/job YAML, so MicroShift compatibility is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only adds/generated CI YAML; no new Ginkgo e2e tests or multi-node assumptions were introduced.
Topology-Aware Scheduling Compatibility ✅ Passed PASS: The PR only adds ci-operator build/mirror config; the new YAML has no pod affinity, topology spread, nodeSelector, replicas, or PDB settings.
Ote Binary Stdout Contract ✅ Passed This PR only changes generated ci-operator YAML; no Go/test binary or suite setup code was added, so there are no process-level stdout writes to flag.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only CI YAML changed; no new Ginkgo e2e tests or network-relevant code were added.
No-Weak-Crypto ✅ Passed The PR only adds CI YAML/job config; the changed files contain no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret-comparison code.
Container-Privileges ✅ Passed No fleetshift-added manifest/job sets privileged, host* flags, SYS_ADMIN, root, or allowPrivilegeEscalation:true.
No-Sensitive-Data-In-Logs ✅ Passed No logging code was added; the diff is limited to CI config/job YAML and contains no passwords, tokens, PII, or other sensitive log output.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@ci-operator/config/fleetshift/fleetshift-poc/fleetshift-fleetshift-poc-main__fleetshift.yaml`:
- Around line 6-12: Update the images configuration to use the expected flat
list of image definitions, removing the nested items wrapper and run_if_changed
from the images block while preserving the fleetshift image settings. If
path-based execution is required, define it under a separate presubmit test. Run
make update to validate the schema and regenerate the jobs.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 9f6f5b72-f90e-4108-8826-4d9d202cf86c

📥 Commits

Reviewing files that changed from the base of the PR and between 939c03b and 680730e.

⛔ Files ignored due to path filters (2)
  • ci-operator/jobs/fleetshift/fleetshift-poc/fleetshift-fleetshift-poc-main-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/fleetshift/fleetshift-poc/fleetshift-fleetshift-poc-main-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/fleetshift/fleetshift-poc/fleetshift-fleetshift-poc-main__fleetshift.yaml

@mshort55

Copy link
Copy Markdown
Contributor

/lgtm

@mshort55

Copy link
Copy Markdown
Contributor

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@mshort55: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 17, 2026
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2026
@openshift-ci

openshift-ci Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alechenninger, mshort55

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

@alechenninger: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit a710bb3 into openshift:main Jul 17, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants