fix(kserve): use llmisvc_core marker for e2e test selection#82043
Conversation
The upstream marker refactor (kserve#5771) replaced @pytest.mark.autoscaling with auto-assigned llmisvc_autoscaling from the filename. The old "not autoscaling" negative filter no longer excludes autoscaling tests, causing them to run without WVA installed and fail. Switch to the positive llmisvc_core marker which conftest auto-assigns to non-autoscaling, non-tracing test files. This correctly excludes autoscaling_hpa, autoscaling_keda, and tracing tests. pvc_storage still needs explicit exclusion as those tests live inside llmisvc_core files. Signed-off-by: James Ostrander <jostrand@redhat.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
WalkthroughKServe CI configurations now select ChangesKServe E2E test filters
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: James Ostrander <jostrand@redhat.com>
|
@jlost: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/pj-rehearse |
|
@jlost: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse help |
|
@jlost: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse auto-ack |
|
@jlost: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@jlost Are the marker changes already synced to midstream? |
vivekk16
left a comment
There was a problem hiding this comment.
Ensure the changes from upstream are already synced to midstream to avoid failing CI in midstream.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlost, vivekk16 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/pj-rehearse skip |
|
@jlost: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Summary
not autoscalingfilter to positivellmisvc_coremarker@pytest.mark.autoscalingwith auto-assignedautoscaling_hpa/autoscaling_kedafrom filenames, sonot autoscalingno longer excludes themllmisvc_coreis auto-assigned by conftest to non-autoscaling, non-tracing files, correctly scoping the jobmasterandrelease-v0.17branchesTest plan
e2e-llm-inference-serviceno longer runs autoscaling testsSummary by CodeRabbit
Updates KServe’s
e2e-llm-inference-serviceProw jobs to change therun-e2e-tests.shtest-selection filter on bothmasterandrelease-v0.17. The jobs now run:"llmisvc_core and cluster_cpu and not pvc_storage"(count:2, suite label:llm-d)This switches selection to the positive
llmisvc_coremarker (which targets core/non-autoscaling/non-tracing LLM inference service tests) while continuing to explicitly excludepvc_storagetests.