Skip to content

Increase memory limit for Classic STS upgrade to fix Go OOM#82039

Open
dustman9000 wants to merge 1 commit into
openshift:mainfrom
dustman9000:fix-sts-upgrade-oom
Open

Increase memory limit for Classic STS upgrade to fix Go OOM#82039
dustman9000 wants to merge 1 commit into
openshift:mainfrom
dustman9000:fix-sts-upgrade-oom

Conversation

@dustman9000

@dustman9000 dustman9000 commented Jul 16, 2026

Copy link
Copy Markdown
Member

The Classic STS upgrade y-minus-1 job OOMs during Go compilation of aws-sdk-go-v2/service/ec2 (massive generated code). Bumping memory limit to 8Gi to fix 3+ consecutive build failures.

Summary by CodeRabbit

  • Increased the Classic STS upgrade y-minus-1 job’s memory limit from 4 GiB to 8 GiB in the ROSA E2E CI configuration.
  • Addresses repeated out-of-memory failures while compiling the generated EC2 service code in aws-sdk-go-v2.

@openshift-ci

openshift-ci Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dustman9000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2026
@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: ae9868d7-cc60-4059-b143-82c7e793deca

📥 Commits

Reviewing files that changed from the base of the PR and between 854204a and 3b05ddd.

📒 Files selected for processing (1)
  • ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__upgrade.yaml

Walkthrough

The ROSA E2E upgrade CI configuration increases the generic resource memory limit from 4Gi to 8Gi.

Changes

ROSA E2E upgrade configuration

Layer / File(s) Summary
Increase upgrade memory limit
ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__upgrade.yaml
The generic resource memory limit is increased from 4Gi to 8Gi.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: bmeng

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: increasing memory for an upgrade job to address Go OOM failures.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Only a CI config memory limit changed; no Ginkgo test titles or dynamic names were added or modified.
Test Structure And Quality ✅ Passed Only a CI config memory limit changed; no Ginkgo test code or patterns were modified.
Microshift Test Compatibility ✅ Passed Only a CI config YAML changed; no new or modified Ginkgo e2e tests were added, so MicroShift API compatibility is not implicated.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only a CI YAML memory limit changed; no Ginkgo e2e tests or node-topology assumptions were added.
Topology-Aware Scheduling Compatibility ✅ Passed Only the CI job memory limit changed from 4Gi to 8Gi; no affinity, selectors, replicas, or topology constraints were added.
Ote Binary Stdout Contract ✅ Passed PR only changes a CI YAML memory limit; no OTE binary code or stdout writes were added.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only a CI YAML memory limit changed; no new Ginkgo e2e tests or network-sensitive code were added.
No-Weak-Crypto ✅ Passed Only a CI memory-limit YAML change was made; no crypto code, constants, or secret comparisons appear in the diff.
Container-Privileges ✅ Passed Only change is 4Gi→8Gi memory in ci-operator config; no privileged, hostPID/hostNetwork/hostIPC, SYS_ADMIN, or allowPrivilegeEscalation fields are present.
No-Sensitive-Data-In-Logs ✅ Passed The diff only raises a CI memory limit from 4Gi to 8Gi; it adds no logging or sensitive data exposure.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@dustman9000: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-online-rosa-e2e-main-upgrade-images openshift-online/rosa-e2e presubmit Ci-operator config changed
periodic-ci-openshift-online-rosa-e2e-main-upgrade-rosa-classic-sts-upgrade-staging-y-minus-2 N/A periodic Ci-operator config changed
periodic-ci-openshift-online-rosa-e2e-main-upgrade-rosa-classic-sts-upgrade-staging-y-minus-3 N/A periodic Ci-operator config changed
periodic-ci-openshift-online-rosa-e2e-main-upgrade-rosa-hcp-upgrade-staging-y-minus-1 N/A periodic Ci-operator config changed
periodic-ci-openshift-online-rosa-e2e-main-upgrade-rosa-hcp-upgrade-staging-y-minus-2 N/A periodic Ci-operator config changed
periodic-ci-openshift-online-rosa-e2e-main-upgrade-rosa-hcp-upgrade-staging-y-minus-3 N/A periodic Ci-operator config changed
periodic-ci-openshift-online-rosa-e2e-main-upgrade-rosa-classic-sts-upgrade-staging-y-minus-1 N/A periodic Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

@dustman9000: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dustman9000

Copy link
Copy Markdown
Member Author

/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main-upgrade-rosa-classic-sts-upgrade-staging-y-minus-1

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant