NO-ISSUE: Make ISO_No_Registry job optional to non 5.0 branches

[pawanpinjarkar]

Make ISO_No_Registry job optional to non 5.0 branches

Summary by CodeRabbit

Makes the Assisted Installer UI lint CI test optional on release branches 4.20–4.23 by setting always_run to false, so it is no longer forced to run unconditionally.

[openshift-ci-robot]

@pawanpinjarkar: This pull request explicitly references no jira issue.

Details

In response to this:

Make ISO_No_Registry job optional to non 5.0 branches

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 7b72c93a-6777-42d2-9c08-117d903906ca

📥 Commits

Reviewing files that changed from the base of the PR and between a092939 and 59d2dab.

⛔ Files ignored due to path filters (4)

• ci-operator/jobs/openshift-assisted/assisted-installer-ui/openshift-assisted-assisted-installer-ui-release-4.20-presubmits.yaml is excluded by !ci-operator/jobs/**
• ci-operator/jobs/openshift-assisted/assisted-installer-ui/openshift-assisted-assisted-installer-ui-release-4.21-presubmits.yaml is excluded by !ci-operator/jobs/**
• ci-operator/jobs/openshift-assisted/assisted-installer-ui/openshift-assisted-assisted-installer-ui-release-4.22-presubmits.yaml is excluded by !ci-operator/jobs/**
• ci-operator/jobs/openshift-assisted/assisted-installer-ui/openshift-assisted-assisted-installer-ui-release-4.23-presubmits.yaml is excluded by !ci-operator/jobs/**

📒 Files selected for processing (4)

• ci-operator/config/openshift-assisted/assisted-installer-ui/openshift-assisted-assisted-installer-ui-release-4.20.yaml
• ci-operator/config/openshift-assisted/assisted-installer-ui/openshift-assisted-assisted-installer-ui-release-4.21.yaml
• ci-operator/config/openshift-assisted/assisted-installer-ui/openshift-assisted-assisted-installer-ui-release-4.22.yaml
• ci-operator/config/openshift-assisted/assisted-installer-ui/openshift-assisted-assisted-installer-ui-release-4.23.yaml

---

Walkthrough

The release 4.20–4.23 Assisted Installer UI CI configurations change the affected test jobs’ always_run setting from true to false.

Changes

Assisted Installer UI CI configuration

Layer / File(s)	Summary
Disable unconditional test execution ci-operator/config/openshift-assisted/assisted-installer-ui/openshift-assisted-assisted-installer-ui-release-4.20.yaml, ...-4.21.yaml, ...-4.22.yaml, ...-4.23.yaml	The affected test entries no longer force execution unconditionally because always_run is set to false.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title matches the main change: it makes the ISO_No_Registry job optional on non-5.0 branches.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR only flips ci-operator always_run/optional flags for presubmit jobs; no Ginkgo It/Describe/Context titles were added or changed.
Test Structure And Quality	✅ Passed	PR changes only ci-operator YAML job configs; no Ginkgo test code or It/Eventually/BeforeEach blocks were modified, so the check is not applicable.
Microshift Test Compatibility	✅ Passed	Diff only changes ci-operator YAML to set always_run:false for ISO_No_Registry jobs; no new Ginkgo e2e tests or MicroShift-unsafe APIs were added.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	Only ci-operator YAML changed to make an existing job optional; no new Ginkgo e2e tests or cluster-topology assumptions were added.
Topology-Aware Scheduling Compatibility	✅ Passed	PASS: PR only flips ci-operator presubmit always_run to false; no deployment manifests, operator code, or scheduling constraints were changed.
Ote Binary Stdout Contract	✅ Passed	PR only changes ci-operator YAML; no process-level code or stdout writes were added.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	No new Ginkgo/e2e test code was added; only ci-operator job config changed always_run=false for existing jobs.
No-Weak-Crypto	✅ Passed	Only ci-operator YAML changed (always_run/trigger); no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret-comparison code was introduced.
Container-Privileges	✅ Passed	Only always_run changed to false in the four ci-operator YAMLs; no privileged, hostPID/Network/IPC, SYS_ADMIN, or allowPrivilegeEscalation settings were found.
No-Sensitive-Data-In-Logs	✅ Passed	The diff only flips always_run and one trigger regex in generated CI configs; no logs or new sensitive literals (passwords/tokens/PII/hostnames/customer data) were introduced.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[pawanpinjarkar]

/pj-rehearse ack

[openshift-merge-bot]

@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[pawanpinjarkar]

/assign @jgyselov

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@pawanpinjarkar: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-assisted-assisted-installer-ui-release-4.20-e2e-agent-compact-ipv4-iso-no-registry	openshift-assisted/assisted-installer-ui	presubmit	Ci-operator config changed
pull-ci-openshift-assisted-assisted-installer-ui-release-4.21-e2e-agent-compact-ipv4-iso-no-registry	openshift-assisted/assisted-installer-ui	presubmit	Ci-operator config changed
pull-ci-openshift-assisted-assisted-installer-ui-release-4.23-e2e-agent-compact-ipv4-iso-no-registry	openshift-assisted/assisted-installer-ui	presubmit	Ci-operator config changed
pull-ci-openshift-assisted-assisted-installer-ui-release-4.22-e2e-agent-compact-ipv4-iso-no-registry	openshift-assisted/assisted-installer-ui	presubmit	Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[openshift-ci]

@pawanpinjarkar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[bfournie]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bfournie, pawanpinjarkar
Once this PR has been reviewed and has the lgtm label, please ask for approval from jgyselov. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift-assisted/assisted-installer-ui/OWNERS
• ci-operator/jobs/openshift-assisted/assisted-installer-ui/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment