OCPBUGS-60401: add the CA bundle as trusted on openstack disconnected

[winiciusallan]

This PR adds to the image registry config the additionalTrustedCA pointing to the user-bundle-ca. We're seeing jobs failing with the following error:

tls: failed to verify certificate: x509: certificate signed by unknown authority

which may explain some failing tests

example of failing job: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-shiftstack-ci-release-4.18-e2e-openstack-singlestackv6/2072516637981937664

Summary by CodeRabbit

• Updates disconnected OpenStack pre-installation CI to trust the user CA bundle by configuring the cluster image registry’s additionalTrustedCA.
• Prevents x509: certificate signed by unknown authority failures when pulling images in disconnected OpenStack jobs.

[openshift-ci-robot]

@winiciusallan: This pull request references Jira Issue OCPBUGS-60401, which is invalid:

• expected the bug to target either version "5.0." or "openshift-5.0.", but it targets "4.20.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This PR adds to the image registry config the additionalTrustedCA pointing to the user-bundle-ca. We're seeing jobs failing with the following error:

tls: failed to verify certificate: x509: certificate signed by unknown authority

which may explain some failing tests

example of failing job: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-shiftstack-ci-release-4.18-e2e-openstack-singlestackv6/2072516637981937664

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 2bb108a8-2119-494e-951d-bc5ed938f006

📥 Commits

Reviewing files that changed from the base of the PR and between a8526e5 and 581d204.

📒 Files selected for processing (1)

• ci-operator/step-registry/ipi/openstack/pre/disconnected/ipi-openstack-pre-disconnected-chain.yaml

---

Walkthrough

The OpenStack disconnected pre-chain now patches the cluster image configuration to reference user-ca-bundle as an additional trusted CA.

Changes

OpenStack disconnected setup

Layer / File(s)	Summary
Configure additional trusted CA ci-operator/step-registry/ipi/openstack/pre/disconnected/ipi-openstack-pre-disconnected-chain.yaml	Adds an oc patch command that sets spec.additionalTrustedCA.name to user-ca-bundle on image.config.openshift.io/cluster.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: vr4manta

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the change: adding the CA bundle as trusted for OpenStack disconnected jobs.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	Only a ci-operator YAML changed; no Ginkgo test titles were added or modified.
Test Structure And Quality	✅ Passed	No Ginkgo test code changed; this PR only updates a step-registry YAML, so the test-quality checklist is not applicable.
Microshift Test Compatibility	✅ Passed	PR only changes a ci-operator YAML chain step; no Ginkgo e2e tests or new test cases were added, so MicroShift compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The PR only patches a ci-operator chain YAML; no Ginkgo tests or SNO-relevant test logic were added or changed.
Topology-Aware Scheduling Compatibility	✅ Passed	The change only patches image.config.openshift.io/cluster to add additionalTrustedCA; it adds no pod scheduling, affinity, replicas, or node selectors.
Ote Binary Stdout Contract	✅ Passed	Only a ci-operator YAML chain step changed; no OTE binary, main/TestMain, or suite-setup stdout code was introduced.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	No new Ginkgo tests were added; the PR only patches step-registry YAML to add additionalTrustedCA.
No-Weak-Crypto	✅ Passed	Change only adds an image.config.openshift.io trusted CA patch in YAML; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparisons.
Container-Privileges	✅ Passed	The changed YAML only adds an oc patch command; no privileged, hostPID/hostNetwork/hostIPC, SYS_ADMIN, root, or allowPrivilegeEscalation settings were introduced.
No-Sensitive-Data-In-Logs	✅ Passed	The only change adds an oc patch for user-ca-bundle; no new logs or sensitive data are introduced.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: winiciusallan
Once this PR has been reviewed and has the lgtm label, please assign stephenfin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• ci-operator/step-registry/ipi/openstack/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@winiciusallan: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-machine-config-operator-main-e2e-openstack-singlestackv6	openshift/machine-config-operator	presubmit	Registry content changed
pull-ci-openshift-machine-config-operator-release-5.1-e2e-openstack-singlestackv6	openshift/machine-config-operator	presubmit	Registry content changed
pull-ci-openshift-machine-config-operator-release-5.0-e2e-openstack-singlestackv6	openshift/machine-config-operator	presubmit	Registry content changed
pull-ci-openshift-machine-config-operator-release-4.23-e2e-openstack-singlestackv6	openshift/machine-config-operator	presubmit	Registry content changed
pull-ci-openshift-machine-config-operator-release-4.22-e2e-openstack-singlestackv6	openshift/machine-config-operator	presubmit	Registry content changed
pull-ci-openshift-machine-config-operator-release-4.21-e2e-openstack-singlestackv6	openshift/machine-config-operator	presubmit	Registry content changed
pull-ci-openshift-machine-config-operator-release-4.20-e2e-openstack-singlestackv6	openshift/machine-config-operator	presubmit	Registry content changed
pull-ci-openshift-machine-config-operator-release-4.19-e2e-openstack-singlestackv6	openshift/machine-config-operator	presubmit	Registry content changed
pull-ci-openshift-machine-config-operator-release-4.18-e2e-openstack-singlestackv6	openshift/machine-config-operator	presubmit	Registry content changed
pull-ci-openshift-installer-main-e2e-openstack-singlestackv6	openshift/installer	presubmit	Registry content changed
pull-ci-openshift-installer-release-5.1-e2e-openstack-singlestackv6	openshift/installer	presubmit	Registry content changed
pull-ci-openshift-installer-release-5.0-e2e-openstack-singlestackv6	openshift/installer	presubmit	Registry content changed
pull-ci-openshift-installer-release-4.23-e2e-openstack-singlestackv6	openshift/installer	presubmit	Registry content changed
pull-ci-openshift-installer-release-4.22-e2e-openstack-singlestackv6	openshift/installer	presubmit	Registry content changed
pull-ci-openshift-installer-release-4.21-e2e-openstack-singlestackv6	openshift/installer	presubmit	Registry content changed
pull-ci-openshift-installer-release-4.20-e2e-openstack-singlestackv6	openshift/installer	presubmit	Registry content changed
pull-ci-openshift-installer-release-4.19-e2e-openstack-singlestackv6	openshift/installer	presubmit	Registry content changed
pull-ci-openshift-installer-release-4.18-e2e-openstack-singlestackv6	openshift/installer	presubmit	Registry content changed
periodic-ci-shiftstack-ci-release-4.18-e2e-openstack-singlestackv6	N/A	periodic	Registry content changed
periodic-ci-shiftstack-ci-release-4.22-e2e-openstack-singlestackv6	N/A	periodic	Registry content changed
periodic-ci-shiftstack-ci-release-4.21-e2e-openstack-singlestackv6	N/A	periodic	Registry content changed
periodic-ci-shiftstack-ci-release-4.20-e2e-openstack-singlestackv6	N/A	periodic	Registry content changed
periodic-ci-shiftstack-ci-release-4.19-e2e-openstack-singlestackv6	N/A	periodic	Registry content changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[winiciusallan]

/pj-rehearse pull-ci-openshift-installer-release-4.22-e2e-openstack-singlestackv6

[winiciusallan]

/pj-rehearse pull-ci-openshift-installer-release-4.22-e2e-openstack-singlestackv6

[openshift-merge-bot]

@winiciusallan: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@winiciusallan: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/rehearse/openshift/installer/release-4.22/e2e-openstack-singlestackv6	581d204	link	unknown	/pj-rehearse pull-ci-openshift-installer-release-4.22-e2e-openstack-singlestackv6

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[winiciusallan]

/pj-rehearse pull-ci-openshift-installer-release-4.22-e2e-openstack-singlestackv6

Install failure, unrelated to the change - it did not even run.

[openshift-merge-bot]

@winiciusallan: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[winiciusallan]

/pj-rehearse pull-ci-openshift-installer-release-4.22-e2e-openstack-singlestackv6

[openshift-merge-bot]

@winiciusallan: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[winiciusallan]

/retest

[winiciusallan]

/pj-rehearse pull-ci-openshift-installer-release-4.22-e2e-openstack-singlestackv6

[openshift-merge-bot]

@winiciusallan: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[dlaw4608]

/pj-rehearse pull-ci-openshift-installer-release-4.22-e2e-openstack-singlestackv6

[openshift-merge-bot]

@dlaw4608: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.