Skip to content

Bump AWS FIPS IPI jobs to m6a.2xlarge instances#82033

Open
mkowalski wants to merge 1 commit into
openshift:mainfrom
mkowalski:bump-fips-ipi-instances
Open

Bump AWS FIPS IPI jobs to m6a.2xlarge instances#82033
mkowalski wants to merge 1 commit into
openshift:mainfrom
mkowalski:bump-fips-ipi-instances

Conversation

@mkowalski

@mkowalski mkowalski commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Sets COMPUTE_NODE_TYPE and CONTROL_PLANE_INSTANCE_TYPE to m6a.2xlarge for e2e-aws-ovn-fips (and e2e-aws-ovn-fips-serial) tests in current development releases (main/master, release-4.22, release-4.23) of installer, kubernetes, machine-config-operator, origin, and the nightly-4.22/4.23 release periodics, per Slack thread.

Replaces #82030, which wrongly targeted CVP cluster pools instead of the IPI jobs.

Summary by CodeRabbit

Updates AWS FIPS IPI CI jobs across OpenShift component and release configurations to use larger m6a.2xlarge compute and control-plane instances. This applies to development-release jobs and nightly 4.22/4.23 e2e-aws-ovn-fips and serial FIPS periodics, helping alleviate resource pressure on the default instances.

The e2e-aws-ovn-fips jobs are hitting resource pressure on the default
m6a.xlarge nodes. Set COMPUTE_NODE_TYPE and CONTROL_PLANE_INSTANCE_TYPE
to m6a.2xlarge for the FIPS tests in current development releases
(main/master, release-4.22, release-4.23) of installer, kubernetes,
machine-config-operator and origin, plus the nightly-4.22/4.23 release
periodics (including e2e-aws-ovn-fips-serial).

Assisted-By: Claude Fable 5
Signed-off-by: Mat Kowalski <mko@redhat.com>
@openshift-ci

openshift-ci Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mkowalski
Once this PR has been reviewed and has the lgtm label, please assign bertinatto, cheesesashimi, stbenjam, tthvo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 87c68fff-8792-4150-bfdb-23154acd35b2

📥 Commits

Reviewing files that changed from the base of the PR and between a8526e5 and e17539b.

📒 Files selected for processing (26)
  • ci-operator/config/openshift-priv/installer/openshift-priv-installer-main.yaml
  • ci-operator/config/openshift-priv/installer/openshift-priv-installer-release-4.22.yaml
  • ci-operator/config/openshift-priv/installer/openshift-priv-installer-release-4.23.yaml
  • ci-operator/config/openshift-priv/kubernetes/openshift-priv-kubernetes-master.yaml
  • ci-operator/config/openshift-priv/kubernetes/openshift-priv-kubernetes-release-4.22.yaml
  • ci-operator/config/openshift-priv/kubernetes/openshift-priv-kubernetes-release-4.23.yaml
  • ci-operator/config/openshift-priv/machine-config-operator/openshift-priv-machine-config-operator-main.yaml
  • ci-operator/config/openshift-priv/machine-config-operator/openshift-priv-machine-config-operator-release-4.22.yaml
  • ci-operator/config/openshift-priv/machine-config-operator/openshift-priv-machine-config-operator-release-4.23.yaml
  • ci-operator/config/openshift-priv/origin/openshift-priv-origin-main.yaml
  • ci-operator/config/openshift-priv/origin/openshift-priv-origin-release-4.22.yaml
  • ci-operator/config/openshift-priv/origin/openshift-priv-origin-release-4.23.yaml
  • ci-operator/config/openshift/installer/openshift-installer-main.yaml
  • ci-operator/config/openshift/installer/openshift-installer-release-4.22.yaml
  • ci-operator/config/openshift/installer/openshift-installer-release-4.23.yaml
  • ci-operator/config/openshift/kubernetes/openshift-kubernetes-master.yaml
  • ci-operator/config/openshift/kubernetes/openshift-kubernetes-release-4.22.yaml
  • ci-operator/config/openshift/kubernetes/openshift-kubernetes-release-4.23.yaml
  • ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-main.yaml
  • ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.22.yaml
  • ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.23.yaml
  • ci-operator/config/openshift/origin/openshift-origin-main.yaml
  • ci-operator/config/openshift/origin/openshift-origin-release-4.22.yaml
  • ci-operator/config/openshift/origin/openshift-origin-release-4.23.yaml
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.22.yaml
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.23.yaml

Walkthrough

The CI configurations for OpenShift FIPS AWS e2e jobs now set both compute and control-plane instance types to m6a.2xlarge, including nightly serial jobs.

Changes

FIPS AWS instance sizing

Layer / File(s) Summary
Propagate instance sizing across FIPS jobs
ci-operator/config/openshift*/**
Adds COMPUTE_NODE_TYPE and CONTROL_PLANE_INSTANCE_TYPE with value m6a.2xlarge to FIPS AWS e2e job environments across private, standard, component, and nightly configurations.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: vr4manta

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: AWS FIPS IPI jobs are updated to use m6a.2xlarge instances.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR only updates ci-operator YAML env vars for FIPS jobs; no Ginkgo test titles or other test-name strings were added or changed.
Test Structure And Quality ✅ Passed PR only changes ci-operator YAML job configs; no Go/Ginkgo test code is touched, so the test-structure check is not applicable.
Microshift Test Compatibility ✅ Passed PASS: PR only updates ci-operator YAML job env for existing FIPS jobs; no Ginkgo tests, APIs, or MicroShift-unsupported features were added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only ci-operator YAML job env vars changed; no Ginkgo test code was added or modified, so SNO compatibility review is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed Only ci-operator test-job YAMLs changed; no deployment manifests, operator code, or controller scheduling logic were modified.
Ote Binary Stdout Contract ✅ Passed PR only edits ci-operator YAML configs; no process-level OTE code or stdout writes were changed.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only ci-operator YAML job env updates changed; no Go/Ginkgo tests were added, so the IPv6/disconnected-network check is not applicable.
No-Weak-Crypto ✅ Passed Diff only adds AWS instance-type env vars (m6a.2xlarge); no weak-crypto, custom crypto, or secret-comparison code was introduced.
Container-Privileges ✅ Passed Touched e2e-aws-ovn-fips blocks only add COMPUTE_NODE_TYPE/CONTROL_PLANE_INSTANCE_TYPE; no privileged/root/capability flags found.
No-Sensitive-Data-In-Logs ✅ Passed The diff only adds AWS instance-type env vars to CI YAML; no logging statements or sensitive data (passwords, tokens, PII, hostnames) were introduced.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from droslean and jubittajohn July 16, 2026 18:26
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@mkowalski: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-kubernetes-master-e2e-aws-ovn-fips openshift/kubernetes presubmit Ci-operator config changed
pull-ci-openshift-kubernetes-release-4.22-e2e-aws-ovn-fips openshift/kubernetes presubmit Ci-operator config changed
pull-ci-openshift-kubernetes-release-4.23-e2e-aws-ovn-fips openshift/kubernetes presubmit Ci-operator config changed
pull-ci-openshift-machine-config-operator-release-4.22-e2e-aws-ovn-fips openshift/machine-config-operator presubmit Ci-operator config changed
pull-ci-openshift-machine-config-operator-main-e2e-aws-ovn-fips openshift/machine-config-operator presubmit Ci-operator config changed
pull-ci-openshift-machine-config-operator-release-4.23-e2e-aws-ovn-fips openshift/machine-config-operator presubmit Ci-operator config changed
pull-ci-openshift-installer-main-e2e-aws-ovn-fips openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.22-e2e-aws-ovn-fips openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.23-e2e-aws-ovn-fips openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-origin-release-4.22-e2e-aws-ovn-fips openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-main-e2e-aws-ovn-fips openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-release-4.23-e2e-aws-ovn-fips openshift/origin presubmit Ci-operator config changed
periodic-ci-openshift-release-main-nightly-4.23-e2e-aws-ovn-fips N/A periodic Ci-operator config changed
periodic-ci-openshift-release-main-nightly-4.23-e2e-aws-ovn-fips-serial N/A periodic Ci-operator config changed
periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-ovn-fips N/A periodic Ci-operator config changed
periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-ovn-fips-serial N/A periodic Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

@mkowalski: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant