Update/sync prow config for Core Networking repos#82026
Conversation
Use the standard config (in particular, lgtm=approve) everywhere.
We aren't using cherry-pick-approved any more; there's no reason to spam current and former QE team members about it.
Mostly synced from CNO, but ovn-kubernetes is slightly different.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: danwinship The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (7)
💤 Files with no reviewable changes (3)
WalkthroughSeven OpenShift Prow plugin configurations simplify restricted-label policies, remove approval and LGTM settings, and revise allowed user or team lists for backport label assignment. ChangesRestricted label policy
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Thank you for repeating what I just said, except with more words and less information. |
|
[REHEARSALNOTIFIER] Note: If this PR includes changes to step registry files ( |
|
@danwinship: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
approve/lgtmconfig. (In particular, don't (unintentionally?) override the openshift-wide lgtm==approve default; it's weird for it to work differently only in some repos.)cherry-pick-approvedstuff, since it's no longer used anywhere and it's dumb to cc a ton of current/former QE people on backport bugs for no reason.backport-risk-assessedto mostly the same as the CNO list in all repos except ovn-kubernetes. Also, remove ex team members./assign @tssurya
Summary by CodeRabbit
approve/lgtmoverrides and relying on OpenShift-wide defaults.cherry-pick-approvedrules and notifications.backport-risk-assessedpermissions with CNO conventions, including anovn-kubernetes-specific allowlist.