Skip to content

fix: add arm64 capability to tests#82025

Open
jan-law wants to merge 2 commits into
openshift:mainfrom
jan-law:grc-arm64
Open

fix: add arm64 capability to tests#82025
jan-law wants to merge 2 commits into
openshift:mainfrom
jan-law:grc-arm64

Conversation

@jan-law

@jan-law jan-law commented Jul 16, 2026

Copy link
Copy Markdown

Follow up to #63142

The images appear to build successfully, but the e2e tests were placed on a cluster without arm64:
https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/stolostron_governance-policy-framework/1064/pull-ci-stolostron-governance-policy-framework-release-2.17-test-e2e-grc-framework/2077493608629407744

  1. Followed https://docs.ci.openshift.org/how-tos/capabilities/#configuration
  2. Ran make jobs

Summary by CodeRabbit

Updates Stolostron Governance Policy Framework CI configuration in ci-operator/config/stolostron/governance-policy-framework so the test-e2e-grc-framework e2e job is constrained to clusters that advertise the arm64 capability. This change is applied across the main and supported release YAMLs (e.g., 2.11–2.17 and 5.0), ensuring e2e runs on arm64-capable clusters instead of non-arm64 ones.

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: f3d8604e-97c5-4927-9ea9-3a94cd811147

📥 Commits

Reviewing files that changed from the base of the PR and between 1ecb044 and e6c317e.

📒 Files selected for processing (2)
  • ci-operator/config/stolostron/governance-policy-framework/stolostron-governance-policy-framework-release-2.17.yaml
  • ci-operator/config/stolostron/governance-policy-framework/stolostron-governance-policy-framework-release-5.0.yaml

Walkthrough

Governance policy framework CI configurations now require arm64 for test-e2e-grc-framework; release 2.17 and 5.0 also update builder image references from Go 1.25 to Go 1.26.

Changes

Governance policy framework CI

Layer / File(s) Summary
Declare ARM64 test capabilities
ci-operator/config/stolostron/governance-policy-framework/*
Main and release configurations require arm64 for test-e2e-grc-framework.
Update Go builder images
ci-operator/config/stolostron/governance-policy-framework/...release-2.17.yaml, ...release-5.0.yaml
Release 2.17 and 5.0 builder references change from go1.25-linux to go1.26-linux.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Suggested labels: rehearsals-ack

Suggested reviewers: gparvin, yiraechristinekim

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: adding arm64 capability to the tests.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS: The PR only updates ci-operator YAML to add arm64 capabilities and Go 1.26 image refs; no Ginkgo test titles or other test-name strings were changed.
Test Structure And Quality ✅ Passed PR only changes ci-operator YAML; no _test.go or Ginkgo test code was modified, so the test-quality check is not applicable.
Microshift Test Compatibility ✅ Passed Only ci-operator YAML was changed; no Ginkgo test code or new test bodies were added, so MicroShift compatibility isn’t implicated.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only CI config/presubmit YAML changed; no Go/Ginkgo test code was added or modified, so SNO compatibility isn’t applicable.
Topology-Aware Scheduling Compatibility ✅ Passed Only CI YAML gained arm64 test/image capabilities; no deployment manifests, operator code, or controllers were changed.
Ote Binary Stdout Contract ✅ Passed Only ci-operator YAML changed; no OTE binary code or process-level stdout writes were modified.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only ci-operator YAML changed; no new Ginkgo e2e test code or networking assumptions were added.
No-Weak-Crypto ✅ Passed The PR only changes CI YAML for arm64 capability and Go builder tags; no weak-crypto algorithms or custom crypto logic are introduced.
Container-Privileges ✅ Passed Diff only adds arm64 capabilities and Go 1.26 builder refs; no privileged, hostPID/Network/IPC, SYS_ADMIN, or allowPrivilegeEscalation settings found.
No-Sensitive-Data-In-Logs ✅ Passed Changed CI YAML only updates Go builder image tags; no passwords, tokens, PII, internal hostnames, or other sensitive log data appears in the diff.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan-law

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2026
@jan-law

jan-law commented Jul 16, 2026

Copy link
Copy Markdown
Author

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@jan-law: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Signed-off-by: Janelle Law <jalaw@redhat.com>
@jan-law

jan-law commented Jul 16, 2026

Copy link
Copy Markdown
Author

/pj-rehearse

@jan-law

jan-law commented Jul 16, 2026

Copy link
Copy Markdown
Author

/pj-rehearse abort
/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@jan-law: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Signed-off-by: Janelle Law <jalaw@redhat.com>
@jan-law

jan-law commented Jul 17, 2026

Copy link
Copy Markdown
Author

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@jan-law: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

@jan-law: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/stolostron/governance-policy-framework/release-2.11/test-e2e-grc-framework 1ecb044 link unknown /pj-rehearse pull-ci-stolostron-governance-policy-framework-release-2.11-test-e2e-grc-framework
ci/rehearse/stolostron/governance-policy-framework/release-5.0/test-e2e-grc-framework 1ecb044 link unknown /pj-rehearse pull-ci-stolostron-governance-policy-framework-release-5.0-test-e2e-grc-framework
ci/rehearse/stolostron/governance-policy-framework/release-2.14/test-e2e-grc-framework 1ecb044 link unknown /pj-rehearse pull-ci-stolostron-governance-policy-framework-release-2.14-test-e2e-grc-framework
ci/rehearse/stolostron/governance-policy-framework/release-2.17/test-e2e-grc-framework 1ecb044 link unknown /pj-rehearse pull-ci-stolostron-governance-policy-framework-release-2.17-test-e2e-grc-framework
ci/rehearse/stolostron/governance-policy-framework/release-2.16/test-e2e-grc-framework 1ecb044 link unknown /pj-rehearse pull-ci-stolostron-governance-policy-framework-release-2.16-test-e2e-grc-framework

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jan-law

jan-law commented Jul 17, 2026

Copy link
Copy Markdown
Author

/pj-rehearse abort
/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@jan-law: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jan-law

jan-law commented Jul 17, 2026

Copy link
Copy Markdown
Author

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@jan-law: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant