Skip to content

NO-ISSUE: Debugging capi tests #82023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
CrystalChun wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −1
Draft

NO-ISSUE: Debugging capi tests #82023

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...erator/config/openshift/assisted-service/openshift-assisted-service-release-ocm-2.16.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ base_images:
hypershift-operator:
name: hypershift-operator
namespace: hypershift
tag: latest
tag: "4.21"
postgresql-13-c9s:
name: postgresql
namespace: ci
Expand Down
4 changes: 4 additions & 0 deletions ...ep-registry/assisted/baremetal/operator/capi/assisted-baremetal-operator-capi-commands.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ then
scp "${SSHOPTS[@]}" "${SHARED_DIR}/assisted-ztp-config" "root@${IP}:assisted-ztp-config"
fi

scp "${SSHOPTS[@]}" "${CLUSTER_PROFILE_DIR}/pull-secret" "root@${IP}:/root/pull-secret"

Comment on lines +29 to +30

@coderabbitai coderabbitai Bot Jul 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔒 Security & Privacy | 🟠 Major | ⚡ Quick win

Remove the remote pull-secret after use.

This newly copied credential remains at /root/pull-secret after the SSH session, including when deployment fails. Add failure-safe cleanup (for example, a remote trap), and restrict the file to mode 600 while it exists.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@ci-operator/step-registry/assisted/baremetal/operator/capi/assisted-baremetal-operator-capi-commands.sh`
around lines 29 - 30, Update the pull-secret transfer command to ensure the
remote /root/pull-secret is mode 600 while present and is removed failure-safely
after use, including when deployment or the SSH session fails; use a remote trap
or equivalent cleanup tied to the operation.

tar -czf - . | ssh "${SSHOPTS[@]}" "root@${IP}" "cat > /root/assisted-service.tar.gz"

# shellcheck disable=SC2087
Expand Down Expand Up @@ -65,6 +67,8 @@ then
source /root/assisted-ztp-config
fi

oc image info "\${HYPERSHIFT_IMAGE}" -a /root/pull-secret
oc image info "\${ASSISTED_OPENSHIFT_INSTALL_RELEASE_IMAGE}" -a /root/pull-secret
./deploy_capi_cluster.sh

EOF