Skip to content

CNTRLPLANE-3564: test(awsprivatelink): add unit test for NoSuchHostedZone handling dur… #9141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Jul 28, 2026
+26 −0
Merged

CNTRLPLANE-3564: test(awsprivatelink): add unit test for NoSuchHostedZone handling dur… #9141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions control-plane-operator/controllers/awsprivatelink/awsprivatelink_controller_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,6 +563,32 @@ func TestReconcileDeletion(t *testing.T) {
expectRequeue: true,
expectFinalizer: true,
},
{
name: "When Route53 hosted zone is already deleted externally it should treat deletion as successful",
awsEndpointSvc: &hyperv1.AWSEndpointService{
ObjectMeta: metav1.ObjectMeta{
Name: "private-router",
Namespace: "clusters-test",
DeletionTimestamp: &now,
Finalizers: []string{finalizer},
},
Status: hyperv1.AWSEndpointServiceStatus{
DNSNames: []string{"api.example.com"},
DNSZoneID: "Z1234567890",
},
},
setupMocks: func(mockCtrl *gomock.Controller) *MockawsClientProvider {
mockBuilder := NewMockawsClientProvider(mockCtrl)
mockEC2 := awsapi.NewMockEC2API(mockCtrl)
mockRoute53 := awsapi.NewMockROUTE53API(mockCtrl)
mockRoute53.EXPECT().ListResourceRecordSets(gomock.Any(), gomock.Any()).Return(
nil, &route53types.NoSuchHostedZone{Message: aws.String("Hosted zone Z1234567890 not found")})
mockBuilder.EXPECT().getClients(gomock.Any()).Return(mockEC2, mockRoute53, nil)
return mockBuilder
},
expectError: false,
expectFinalizer: false,
},
}

for _, tc := range testCases {
Expand Down