[release-4.22][OCPBUGS-88312] cherry-pick use in-cluster service for oauth-server - #9127
[release-4.22][OCPBUGS-88312] cherry-pick use in-cluster service for oauth-server#9127Tamas-Biro1 wants to merge 3 commits into
Conversation
oauth-openshift performs a self-call using the MasterURL when users click 'Display Token'. This can fail depending on whether the URL is public or private. Public URL: fails when outbound connectivity is restricted. Private URL: may fail due to private DNS resolution issues. Use the in-cluster service URL to ensure reliable self-calls.
use constants from the same package instead of creating new consts
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Tamas-Biro1 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @Tamas-Biro1. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
1fcc34c to
b01983b
Compare
Fix package conflicts when cherry-picking to 4.22
b01983b to
f0f25a3
Compare
What this PR does / why we need it:
When a user clicks “Display Token”, the oauth-openshift service attempts to call itself using the cluster’s API endpoint.
This self-call fails depending on whether the oauth-server is configured a public or private service URL as MasterURL.
In case of a public URL and control plane outbound connecitivty is restricted, the call fails.
In case a private URL, it can happen that the DNS is also a private one, and DNS resolution fails.
Which issue(s) this PR fixes:
Fixes OCPBUGS-88312
Special notes for your reviewer:
Checklist: