CNTRLPLANE-3890: Add product-cli unit tests for HCP create cluster - #9107
CNTRLPLANE-3890: Add product-cli unit tests for HCP create cluster#9107mehabhalodiya wants to merge 1 commit into
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@mehabhalodiya: This pull request references CNTRLPLANE-3890 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
openshift-ci
Bot
added
do-not-merge/needs-area
area/platform/aws
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (5)
📒 Files selected for processing (5)
🚧 Files skipped from review as they are similar to previous changes (4)
📝 WalkthroughWalkthroughAdds Go tests for agent, AWS, Azure, KubeVirt, and OpenStack cluster creation. The tests validate command metadata, flag registration and defaults, required annotations, inheritance, developer-only flag exclusions, and exact flag sets. Rendering tests use deterministic inputs and temporary credential files, invoke cluster creation, and compare generated manifests with fixtures. Suggested reviewers: 🚥 Pre-merge checks | ✅ 11✅ Passed checks (11 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
openshift-ci
Bot
added
area/platform/openstack
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mehabhalodiya The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9107 +/- ##
==========================================
+ Coverage 44.51% 44.65% +0.14%
==========================================
Files 774 774
Lines 96997 97098 +101
==========================================
+ Hits 43179 43363 +184
+ Misses 50830 50735 -95
- Partials 2988 3000 +12 see 14 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
product-cli/cmd/cluster/openstack/create_test.go (1)
17-93: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueConsider adding a developer-only flag exclusion subtest for consistency.
Agent, AWS, and KubeVirt sibling test files each assert specific developer-only flags are absent; this file doesn't. Optional for consistency across the cohort, not blocking.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@product-cli/cmd/cluster/openstack/create_test.go` around lines 17 - 93, Optionally add a developer-only flag exclusion subtest alongside the existing NewCreateCommand flag tests, asserting the relevant developer-only flags are absent for the OpenStack create command. Follow the corresponding exclusion assertions in the Agent, AWS, and KubeVirt sibling tests while keeping the existing expected-flags coverage unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@product-cli/cmd/cluster/agent/create_test.go`:
- Around line 44-62: The required-flag tests are vacuous because they mark
pull-secret on a synthetic parent instead of verifying command wiring. In
product-cli/cmd/cluster/agent/create_test.go lines 44-62 and
product-cli/cmd/cluster/aws/create_test.go lines 99-117, add each command to the
actual cluster parent setup, remove the test’s manual MarkPersistentFlagRequired
call, and assert the inherited pull-secret flag on the resulting command tree.
---
Nitpick comments:
In `@product-cli/cmd/cluster/openstack/create_test.go`:
- Around line 17-93: Optionally add a developer-only flag exclusion subtest
alongside the existing NewCreateCommand flag tests, asserting the relevant
developer-only flags are absent for the OpenStack create command. Follow the
corresponding exclusion assertions in the Agent, AWS, and KubeVirt sibling tests
while keeping the existing expected-flags coverage unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 090e068f-c65a-4316-a888-5edb8e0ee03f
📒 Files selected for processing (4)
product-cli/cmd/cluster/agent/create_test.goproduct-cli/cmd/cluster/aws/create_test.goproduct-cli/cmd/cluster/kubevirt/create_test.goproduct-cli/cmd/cluster/openstack/create_test.go
1b8806c to
de0d041
Compare
|
The tests themselves look correct — flag registration, defaults, and developer-only exclusion are all properly verified. That said, I'd suggest aligning with the same approach Bryan flagged on #9121: adding fixture-based tests that invoke the command with For example (not tested, just to illustrate the shape): func TestCreateCluster(t *testing.T) {
ctx := framework.InterruptableContext(t.Context())
t.Setenv("FAKE_CLIENT", "true")
tempDir := t.TempDir()
// set up credential/pull-secret files in tempDir...
flags := pflag.NewFlagSet("test", pflag.ContinueOnError)
coreOpts := core.DefaultOptions()
core.BindDeveloperOptions(coreOpts, flags)
agentOpts := agent.DefaultOptions()
agent.BindDeveloperOptions(agentOpts, flags)
if err := flags.Parse([]string{
"--name=example",
"--pull-secret=" + pullSecretFile,
"--agent-namespace=test-ns",
"--render-sensitive",
}); err != nil {
t.Fatalf("failed to parse flags: %v", err)
}
manifestsFile := filepath.Join(tempDir, "manifests.yaml")
coreOpts.Render = true
coreOpts.RenderInto = manifestsFile
if err := core.CreateCluster(ctx, coreOpts, agentOpts); err != nil {
t.Fatalf("failed to create cluster: %v", err)
}
manifests, err := os.ReadFile(manifestsFile)
if err != nil {
t.Fatalf("failed to read manifests: %v", err)
}
testutil.CompareWithFixture(t, manifests)
} |
de0d041 to
6c759d7
Compare
openshift-ci
Bot
added
the
area/platform/azure
There was a problem hiding this comment.
🧹 Nitpick comments (1)
product-cli/cmd/cluster/kubevirt/create_test.go (1)
60-71: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueConsider adding the
pull-secretinheritance case here too.
NewCreateCommandmarkspull-secretpersistent-required (cmd/cluster/kubevirt/create.go), but unlike the agent/AWS suites this file has no test covering it. Same gap inproduct-cli/cmd/cluster/openstack/create_test.go.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@product-cli/cmd/cluster/kubevirt/create_test.go` around lines 60 - 71, Extend the NewCreateCommand tests in the KubeVirt and OpenStack create suites to verify that the pull-secret flag is inherited as a persistent required flag, matching the existing agent/AWS coverage. Use the pull-secret flag definition and its required/persistent properties, while preserving the current developer-only flag assertions.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@product-cli/cmd/cluster/kubevirt/create_test.go`:
- Around line 60-71: Extend the NewCreateCommand tests in the KubeVirt and
OpenStack create suites to verify that the pull-secret flag is inherited as a
persistent required flag, matching the existing agent/AWS coverage. Use the
pull-secret flag definition and its required/persistent properties, while
preserving the current developer-only flag assertions.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 7d0b8811-b981-49d5-9c70-95b8819dcd6e
⛔ Files ignored due to path filters (5)
product-cli/cmd/cluster/agent/testdata/zz_fixture_TestCreateCluster_When_minimal_flags_are_provided__it_should_render_correctly.yamlis excluded by!**/testdata/**product-cli/cmd/cluster/aws/testdata/zz_fixture_TestCreateCluster_When_minimal_flags_are_provided__it_should_render_correctly.yamlis excluded by!**/testdata/**product-cli/cmd/cluster/azure/testdata/zz_fixture_TestCreateCluster_When_minimal_flags_are_provided__it_should_render_correctly.yamlis excluded by!**/testdata/**product-cli/cmd/cluster/kubevirt/testdata/zz_fixture_TestCreateCluster_When_minimal_flags_are_provided__it_should_render_correctly.yamlis excluded by!**/testdata/**product-cli/cmd/cluster/openstack/testdata/zz_fixture_TestCreateCluster_When_minimal_flags_are_provided__it_should_render_correctly.yamlis excluded by!**/testdata/**
📒 Files selected for processing (5)
product-cli/cmd/cluster/agent/create_test.goproduct-cli/cmd/cluster/aws/create_test.goproduct-cli/cmd/cluster/azure/create_test.goproduct-cli/cmd/cluster/kubevirt/create_test.goproduct-cli/cmd/cluster/openstack/create_test.go
The four platforms — AWS, KubeVirt, OpenStack, and Agent — have no product-cli cluster creation tests at all. Signed-off-by: mehabhalodiya <mehabhalodiya@gmail.com>
6c759d7 to
bc9800c
Compare
|
@mehabhalodiya: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
Scheduling tests matching the |
3 participants
The four platforms — AWS, KubeVirt, OpenStack, and Agent — have no product-cli cluster creation tests at all.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes https://redhat.atlassian.net/browse/CNTRLPLANE-3890
Special notes for your reviewer:
Checklist:
Summary by CodeRabbit
pull-secret.