Skip to content

CNTRLPLANE-3772: promote ExternalOIDCWithUpstreamParity to Default #8952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ShazaAldawamneh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

CNTRLPLANE-3772: promote ExternalOIDCWithUpstreamParity to Default #8952

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion control-plane-operator/featuregates/featuregates.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ var (
allFeatures = featuregates.NewFeatureSetAwareFeatures()

externalOIDCWithUIDAndExtraClaimMappingsFeature = featuregates.NewFeature(ExternalOIDCWithUIDAndExtraClaimMappings, featuregates.WithEnableForFeatureSets(configv1.TechPreviewNoUpgrade, configv1.Default))
externalOIDCWithUpstreamParityFeature = featuregates.NewFeature(ExternalOIDCWithUpstreamParity, featuregates.WithEnableForFeatureSets(configv1.TechPreviewNoUpgrade))
externalOIDCWithUpstreamParityFeature = featuregates.NewFeature(ExternalOIDCWithUpstreamParity, featuregates.WithEnableForFeatureSets(configv1.TechPreviewNoUpgrade, configv1.Default))
)

@jparrill jparrill Jul 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The upstream openshift/api PR #2915 that promotes this gate to Default hasn't merged yet. The vendored CRDs in this repo (hostedclusters-Hypershift-Default.crd.yaml) don't include the gated fields (discoveryURL, userValidationRules, expression) in the Default schema — so this promotion has no functional effect until that vendor bump lands.

Could you add a note in the PR description marking openshift/api#2915 as a dependency? That way the ordering is explicit for anyone tracking it.


func init() {
Expand Down
Loading