Skip to content

[release-ocm-2.13] ACM-35866: CVE-2026-39828 Bump golang.org/x/crypto to v0.52.0 using replace directive (api module)#10614

Open
shay23bra wants to merge 1 commit into
openshift:release-ocm-2.13from
shay23bra:cve-CVE-2026-39828-ba0784a9-7dbc46
Open

[release-ocm-2.13] ACM-35866: CVE-2026-39828 Bump golang.org/x/crypto to v0.52.0 using replace directive (api module)#10614
shay23bra wants to merge 1 commit into
openshift:release-ocm-2.13from
shay23bra:cve-CVE-2026-39828-ba0784a9-7dbc46

Conversation

@shay23bra

Copy link
Copy Markdown
Contributor

Bump golang.org/x/crypto to v0.52.0 to fix CVE-2026-39828 using a replace directive

Strategy Selection

Strategies Not Applicable

  • Direct dependency version bump
    Not applicable: dependency is indirect. Direct version bumps only work for explicitly required modules.

  • Direct dependency major version upgrade
    Not applicable: dependency is indirect. Major version upgrades only apply to direct dependencies.

  • Indirect dependency fix via parent update

    • Suitable versions found for introducer:
      • k8s.io/client-go@v1.5.2
    • No suitable versions found for introducers:
      • github.com/gogo/protobuf
      • github.com/onsi/ginkgo
      • github.com/openshift/custom-resource-status
      • github.com/go-openapi/loads
      • github.com/go-openapi/strfmt
      • github.com/openshift/hive/apis
      • github.com/go-openapi/analysis
      • google.golang.org/appengine
      • github.com/go-openapi/validate
      • github.com/openshift/assisted-service
      • github.com/openshift/api
      • k8s.io/api
      • k8s.io/apimachinery
      • k8s.io/component-base
      • sigs.k8s.io/controller-runtime
      • k8s.io/apiextensions-apiserver
      • golang.org/x/net
      • go.mongodb.org/mongo-driver
  • Indirect to direct dependency conversion
    Attempted to pin golang.org/x/crypto to a fixed version, but Go reverted it to indirect at v0.35.0. No other module requires this version directly, so the explicit requirement was automatically removed by Go's module resolution.

✓ Successful Strategy: Replace directive workaround

Added replace directive to override module resolution. Used as last resort when standard updates fail.

https://redhat.atlassian.net/browse/ACM-35866


This PR was automatically generated by the CVE Automation tool.
For questions or issues, reach out in #cve-automation.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 12, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@shay23bra: This pull request references ACM-35866 which is a valid jira issue.

Details

In response to this:

Bump golang.org/x/crypto to v0.52.0 to fix CVE-2026-39828 using a replace directive

Strategy Selection

Strategies Not Applicable

  • Direct dependency version bump
    Not applicable: dependency is indirect. Direct version bumps only work for explicitly required modules.

  • Direct dependency major version upgrade
    Not applicable: dependency is indirect. Major version upgrades only apply to direct dependencies.

  • Indirect dependency fix via parent update

  • Suitable versions found for introducer:

    • k8s.io/client-go@v1.5.2
  • No suitable versions found for introducers:

    • github.com/gogo/protobuf
    • github.com/onsi/ginkgo
    • github.com/openshift/custom-resource-status
    • github.com/go-openapi/loads
    • github.com/go-openapi/strfmt
    • github.com/openshift/hive/apis
    • github.com/go-openapi/analysis
    • google.golang.org/appengine
    • github.com/go-openapi/validate
    • github.com/openshift/assisted-service
    • github.com/openshift/api
    • k8s.io/api
    • k8s.io/apimachinery
    • k8s.io/component-base
    • sigs.k8s.io/controller-runtime
    • k8s.io/apiextensions-apiserver
    • golang.org/x/net
    • go.mongodb.org/mongo-driver
  • Indirect to direct dependency conversion
    Attempted to pin golang.org/x/crypto to a fixed version, but Go reverted it to indirect at v0.35.0. No other module requires this version directly, so the explicit requirement was automatically removed by Go's module resolution.

✓ Successful Strategy: Replace directive workaround

Added replace directive to override module resolution. Used as last resort when standard updates fail.

https://redhat.atlassian.net/browse/ACM-35866


This PR was automatically generated by the CVE Automation tool.
For questions or issues, reach out in #cve-automation.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jul 12, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 01b502d7-1b71-4ff5-a07d-aedf440843cf

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 12, 2026
@openshift-ci openshift-ci Bot requested review from carbonin and eliorerz July 12, 2026 14:18
@openshift-ci openshift-ci Bot added the api-review Categorizes an issue or PR as actively needing an API review. label Jul 12, 2026
@shay23bra

Copy link
Copy Markdown
Contributor Author

/retest

1 similar comment
@cve-automation

Copy link
Copy Markdown

/retest

@gamli75

gamli75 commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

/retest-required
/approve

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 14, 2026
@codecov

codecov Bot commented Jul 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 42.84%. Comparing base (7552ac1) to head (7989cdc).
⚠️ Report is 8 commits behind head on release-ocm-2.13.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           release-ocm-2.13   #10614      +/-   ##
====================================================
+ Coverage             42.77%   42.84%   +0.06%     
====================================================
  Files                   346      347       +1     
  Lines                 65935    66297     +362     
====================================================
+ Hits                  28204    28404     +200     
- Misses                35196    35337     +141     
- Partials               2535     2556      +21     

see 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gamli75

gamli75 commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

/override ci/prow/e2e-ai-operator-disconnected-capi

@openshift-ci

openshift-ci Bot commented Jul 14, 2026

Copy link
Copy Markdown

@gamli75: Overrode contexts on behalf of gamli75: ci/prow/e2e-ai-operator-disconnected-capi

Details

In response to this:

/override ci/prow/e2e-ai-operator-disconnected-capi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@shay23bra

Copy link
Copy Markdown
Contributor Author

/retest

@gamli75

gamli75 commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

/approve
/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification

No second-stage tests were triggered for this PR.

This can happen when:

  • The changed files don't match any pipeline_run_if_changed patterns
  • All files match pipeline_skip_if_only_changed patterns
  • No pipeline-controlled jobs are defined for the release-ocm-2.13 branch

Use /test ? to see all available tests.

@openshift-ci

openshift-ci Bot commented Jul 14, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gamli75, shay23bra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 061bc9d and 2 for PR HEAD 7989cdc in total

@gamli75

gamli75 commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

/override ci/prow/edge-e2e-ai-operator-disconnected-capi

@openshift-ci

openshift-ci Bot commented Jul 14, 2026

Copy link
Copy Markdown

@gamli75: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • ci/prow/edge-e2e-ai-operator-disconnected-capi

Only the following failed contexts/checkruns were expected:

  • ci/prow/ci-index
  • ci/prow/e2e-ai-operator-disconnected-capi
  • ci/prow/e2e-ai-operator-ztp-capi
  • ci/prow/images
  • ci/prow/lint
  • ci/prow/mce-images
  • ci/prow/unit-test
  • ci/prow/verify-generated-code
  • pull-ci-openshift-assisted-service-assisted-version-placeholder-images
  • pull-ci-openshift-assisted-service-assisted-version-placeholder-lint
  • pull-ci-openshift-assisted-service-assisted-version-placeholder-unit-test
  • pull-ci-openshift-assisted-service-assisted-version-placeholder-verify-generated-code
  • pull-ci-openshift-assisted-service-master-mce-images
  • pull-ci-openshift-assisted-service-release-ocm-2.11-ci-index
  • pull-ci-openshift-assisted-service-release-ocm-2.11-e2e-ai-operator-disconnected-capi
  • pull-ci-openshift-assisted-service-release-ocm-2.11-e2e-ai-operator-ztp-capi
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override ci/prow/edge-e2e-ai-operator-disconnected-capi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD b86b908 and 1 for PR HEAD 7989cdc in total

@shay23bra

Copy link
Copy Markdown
Contributor Author

/retest

@gamli75

gamli75 commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

/override ci/prow/e2e-ai-operator-disconnected-capi

@openshift-ci

openshift-ci Bot commented Jul 15, 2026

Copy link
Copy Markdown

@gamli75: Overrode contexts on behalf of gamli75: ci/prow/e2e-ai-operator-disconnected-capi

Details

In response to this:

/override ci/prow/e2e-ai-operator-disconnected-capi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci

openshift-ci Bot commented Jul 15, 2026

Copy link
Copy Markdown

@shay23bra: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ai-operator-ztp-capi 7989cdc link unknown /test e2e-ai-operator-ztp-capi
ci/prow/e2e-ai-operator-disconnected-capi 7989cdc link true /test e2e-ai-operator-disconnected-capi

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants