Add --enabled-override for manual base image release runs#3050
Add --enabled-override for manual base image release runs#3050thegreyd wants to merge 2 commits into
Conversation
Allow operators to bypass base_image_release.enabled: false when invoking images:release-to-base-repo, with clear qualification errors when the image still does not qualify. Co-authored-by: Cursor <cursoragent@cursor.com> rh-pre-commit.version: 2.4.0 rh-pre-commit.check-secrets: ENABLED
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (6)
👮 Files not reviewed due to content moderation or server errors (6)
WalkthroughThis PR adds an ChangesBase Image Release Enabled Override
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Replace the separate failure-reason helper with BaseImageReleaseQualification so the decision and message come from a single code path. Co-authored-by: Cursor <cursoragent@cursor.com> rh-pre-commit.version: 2.4.0 rh-pre-commit.check-secrets: ENABLED
|
@thegreyd: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Summary
--enabled-overridetodoozer images:release-to-base-reposo operators can manually run snapshot→release whenbase_image_release.enabledis false in image or group configbase_only/golang images on non-test assemblies; does not replace metadatabase_image_release.forceTest plan
make test(all packages pass on Python 3.11 venv)should_trigger_base_image_release(enabled_override=...)Made with Cursor