[BUG] Fix NPE when creating match-all composable index template without inline template block (#22420) - #22630
Open
waterWang wants to merge 1 commit into
Conversation
Contributor
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
Contributor
|
❌ Gradle check result for 6ff7f79: Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #22420
When creating a composable index template with a match-all pattern (
*) and no inlinetemplateblock, the request validation inPutComposableIndexTemplateAction.validateIndexTemplate()throws a NullPointerException because it callsindexTemplate.template().settings()without checking iftemplate()returns null.Root Cause
indexTemplate.template()returnsnullwhen no inlinetemplateblock is provided (which is valid per the API spec). The null reference is then dereferenced for.settings().Fix
Added a null check for
indexTemplate.template()before accessing.settings(). Whentemplate()is null, the hidden index validation is skipped (no inline settings to validate).Related
Testing