Skip to content

[BUG] Dynamic pruning failure in cardinality aggregation falls back instead of failing the shard (#22582) #22629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
waterWang wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[BUG] Dynamic pruning failure in cardinality aggregation falls back instead of failing the shard (#22582) #22629

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions server/src/main/java/org/opensearch/search/aggregations/metrics/CardinalityAggregator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
import org.apache.lucene.util.BytesRef;
import org.apache.lucene.util.FixedBitSet;
import org.apache.lucene.util.RamUsageEstimator;
import org.opensearch.OpenSearchStatusException;

import org.opensearch.common.Nullable;
import org.opensearch.common.hash.MurmurHash3;
import org.opensearch.common.lease.Releasable;
Expand All @@ -65,7 +65,7 @@
import org.opensearch.common.util.LongArray;
import org.opensearch.common.util.ObjectArray;
import org.opensearch.core.common.unit.ByteSizeValue;
import org.opensearch.core.rest.RestStatus;

import org.opensearch.index.fielddata.SortedBinaryDocValues;
import org.opensearch.index.fielddata.SortedNumericDoubleValues;
import org.opensearch.search.aggregations.Aggregator;
Expand Down Expand Up @@ -278,6 +278,7 @@ private boolean tryScoreWithPruningCollector(LeafReaderContext ctx, Collector pr
Weight weight = context.query().rewrite(context.searcher()).createWeight(context.searcher(), ScoreMode.TOP_DOCS, 1f);
Scorer scorer = weight.scorer(ctx);
if (scorer == null) {
Releasables.close(pruningCollector);
return false;
}
pruningCollector.setScorer(scorer);
Expand All @@ -287,13 +288,14 @@ private boolean tryScoreWithPruningCollector(LeafReaderContext ctx, Collector pr
pruningCollector.postCollect();
Releasables.close(pruningCollector);
} catch (Exception e) {
throw new OpenSearchStatusException(
"Failed when performing dynamic pruning in cardinality aggregation. You can set cluster setting ["
+ CARDINALITY_AGGREGATION_PRUNING_THRESHOLD.getKey()
+ "] to 0 to disable.",
RestStatus.INTERNAL_SERVER_ERROR,
Releasables.closeWhileHandlingException(pruningCollector);
logger.warn(
"Dynamic pruning failed for cardinality aggregation, falling back to non-pruning path. "
+ "You can set cluster setting [{}] to 0 to disable this optimization.",
CARDINALITY_AGGREGATION_PRUNING_THRESHOLD.getKey(),
e
);
return false;
}
return true;
}
Expand Down
Loading