Skip to content

Bound TaskExecutorTests latch waits #22627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cragkhit wants to merge 1 commit into from
Closed

Bound TaskExecutorTests latch waits #22627

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions server/src/test/java/org/opensearch/cluster/service/TaskExecutorTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,8 +213,8 @@ public TimeValue timeout() {
submitTask("unblock-task", unblockTask);

block.countDown();
block2.await();
blockCompleted.await();
assertTrue(block2.await(10, TimeUnit.SECONDS));
assertTrue(blockCompleted.await(10, TimeUnit.SECONDS));
}

public void testTimeoutTask() throws Exception {
Expand Down Expand Up @@ -257,7 +257,7 @@ public void onFailure(String source, Exception e) {
};
submitTask("block-task", test2);

timedOut.await();
assertTrue(timedOut.await(10, TimeUnit.SECONDS));
block.countDown();
final CountDownLatch allProcessed = new CountDownLatch(1);
TestTask test3 = new TestTask() {
Expand All @@ -273,7 +273,7 @@ public void onFailure(String source, Exception e) {
}
};
submitTask("block-task", test3);
allProcessed.await(); // executed another task to double check that execute on the timed out update task is not called...
assertTrue(allProcessed.await(10, TimeUnit.SECONDS)); // executed another task to double check that execute on the timed out update task is not called...
assertThat(executeCalled.get(), equalTo(false));
}

Expand Down Expand Up @@ -304,7 +304,7 @@ public void testPrioritizedTasks() throws Exception {
}

block.close();
latch.await();
assertTrue(latch.await(10, TimeUnit.SECONDS));

Priority prevPriority = null;
for (PrioritizedTask task : tasks) {
Expand Down
Loading