Skip to content

gRPC ExtraFields indexing: Add support for double, int and long - #22623

Open
laminelam wants to merge 8 commits into
opensearch-project:mainfrom
laminelam:feature/double_int_long_proto
Open

gRPC ExtraFields indexing: Add support for double, int and long #22623
laminelam wants to merge 8 commits into
opensearch-project:mainfrom
laminelam:feature/double_int_long_proto

Conversation

@laminelam

Copy link
Copy Markdown
Contributor

Resolves #22622

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Lamine Idjeraoui added 8 commits June 5, 2026 14:25
Signed-off-by: Lamine Idjeraoui <lidjeraoui@apple.com>
Signed-off-by: Lamine Idjeraoui <lidjeraoui@apple.com>
cast to long for code readability

Signed-off-by: Lamine Idjeraoui <lidjeraoui@apple.com>
simplified the decodeLongLEAt method to direct decode the bytes

Signed-off-by: Lamine Idjeraoui <lidjeraoui@apple.com>
Signed-off-by: Lamine Idjeraoui <lidjeraoui@apple.com>
Signed-off-by: Lamine Idjeraoui <lidjeraoui@apple.com>
Signed-off-by: Lamine Idjeraoui <lidjeraoui@apple.com>
@laminelam
laminelam requested a review from a team as a code owner July 31, 2026 21:38
@github-actions github-actions Bot added enhancement Enhancement or improvement to existing feature or request Indexing:Performance labels Jul 31, 2026
@laminelam laminelam changed the title Feature/double int long proto gRPC ExtraFields indexing: Add support for double, int and long Jul 31, 2026
@github-actions

Copy link
Copy Markdown
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🧪 PR contains tests
🔒 No security concerns identified
✅ No TODO sections
🔀 No multiple PR themes
⚡ No major issues detected

@github-actions

Copy link
Copy Markdown
Contributor

✅ Gradle check result for 223fa33: SUCCESS

@codecov

codecov Bot commented Jul 31, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.39%. Comparing base (bacf3f6) to head (223fa33).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...uest/document/bulk/ExtraFieldValuesProtoUtils.java 83.33% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #22623      +/-   ##
============================================
- Coverage     71.39%   71.39%   -0.01%     
+ Complexity    76808    76803       -5     
============================================
  Files          6148     6148              
  Lines        357994   358030      +36     
  Branches      52179    52182       +3     
============================================
+ Hits         255607   255614       +7     
- Misses        82054    82083      +29     
  Partials      20333    20333              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhancement or improvement to existing feature or request Indexing:Performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] gRPC ExtraFields indexing: Add support for double, int and long

1 participant