Add mapping for CheckForNull to JSpecify annotation - #1179
Merged
Conversation
zbynek
force-pushed
the
patch-1
branch
2 times, most recently
from
July 30, 2026 21:34
3b4dc33 to
fbcfe6c
Compare
Contributor
Author
succeeds but fails locally -- most of the failed tests seem to be related to openrewrite/rewrite#8355 -- @timtebeek looped. |
zbynek
marked this pull request as ready for review
July 30, 2026 21:52
timtebeek
self-requested a review
July 30, 2026 22:14
timtebeek
approved these changes
Jul 30, 2026
timtebeek
left a comment
Member
There was a problem hiding this comment.
Thanks a lot, also for the helpful link explaining the nuances. I've rebased and will merge when CI succeeds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
When migrating to JSpecify.
javax.annotation.CheckForNullis now replaced byorg.jspecify.annotations.Nullable.Semantically
CheckForNullis closer toorg.jspecify.annotations.Nullablethanjavax.annotation.Nullableis (see StackOverflow), so this is a safe change.What's your motivation?
javax.annotationto avoid manual steps.@CheckForNull Object[]toObject @CheckForNull[], but then fails to replace it, resulting in code that does not compile (the old annotation does not haveTYPE_USEtarget).Anything in particular you'd like reviewers to focus on?
🤷
Anyone you would like to review specifically?
🤷
Have you considered any alternatives or workarounds?
Make a custom .yml recipe.
Any additional context
Projects using SpotBugs for null analysis likely prefer
@CheckForNulloverjavax.annotation.Nullable, so they might benefit from this change.Checklist