Repository navigation
chore(dev): support an explicit test worker budget and use frozen Effect installs - #921
Merged
Merged
Conversation
tt-a1i
marked this pull request as ready for review
November 13, 2026 16:32
github-actions
Bot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Node and Vitest launchers use a fixed maximum of four concurrent files, so contributors cannot choose a different budget for a large or constrained machine. The subagent Effect notes also instruct developers to install floating beta packages despite the root manifest's tested pins and the earlier packed-install failure in #533.
Value
Contributors can choose a worker count for their own machines and install the same dependency cohort that CI uses. No elapsed-time improvement has been established.
Approach
Read an optional
OPENPI_TEST_WORKERSin the existing runner and validate it against the machine's available parallelism. Both parallel launchers use that number. The existing default and the serial Windows process group keep their current behavior. Update the historical Effect notes to point to the frozen root install.Validation
bun run checkand all six runner tests, including fixtures with an explicit worker count, invalid values, serial isolation, sharding and child failure propagation.bun run testwith the default budget (2,476 Node passes, 8 skips, 1,652 UI passes). The checkout also contained the Web fixes and their additional tests.Impact
Contributor tooling and install documentation only. CI jobs continue using their configured defaults. Pi runtime behavior, package dependency versions, model tools and persisted settings are unchanged.