Skip to content

Repair mismatch between submissions and metadata setting groups #5388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mauromsl merged 2 commits into from
Jul 15, 2026
Merged

Repair mismatch between submissions and metadata setting groups #5388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
026f63d
fix #5386 Repair mismatch between submissions and metadata setting gr…
joemull Jul 10, 2026
d2c5d5b
fix #5386 Finish fixing metadata setting group
joemull Jul 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/core/logic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,6 +412,11 @@ def get_settings_to_edit(display_group, journal, user):
"general", "hide_editors_from_authors", journal
),
},
]
setting_group = "general"

elif display_group == "metadata":
group_of_settings = [
{
"name": "author_job_title",
"object": setting_handler.get_setting(
Expand All @@ -431,7 +436,7 @@ def get_settings_to_edit(display_group, journal, user):
),
},
]
setting_group = "general"
setting_group = "metadata"

elif display_group == "review":
group_of_settings = [
Expand Down
5 changes: 5 additions & 0 deletions src/templates/admin/core/manager/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,11 @@ <h2>Journal Settings</h2>
<a class="button" href="{% url 'home_settings_index' %}">Home Page</a>
<a class="button" href="{% url 'core_edit_settings_group' "images" %}">Images</a>
<a class="button" href="{% url 'core_edit_settings_group' "styling" %}">Styling</a>
<a
class="button"
href="{% url 'core_edit_settings_group' "metadata" %}">
Metadata
</a>
<a class="button" href="{% url 'core_settings_index' %}">All Settings</a>
</div>
</div>
Expand Down
2 changes: 2 additions & 0 deletions src/templates/admin/core/manager/settings/group.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@
{% include "admin/elements/forms/group_journal_images.html" with form=attr_form %}
{% elif group == 'submission' %}
{% include "admin/elements/forms/group_submission.html" %}
{% elif group == 'metadata' %}
{% include "admin/elements/forms/group_metadata.html" %}
{% elif group == 'styling' %}
{% include "admin/elements/forms/group_styling.html" %}
{% elif group == 'article' %}
Expand Down
8 changes: 8 additions & 0 deletions src/templates/admin/elements/forms/group_metadata.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
<div class="title-area">
<h2>Metadata settings</h2>
</div>
<div class="content">
{% include "admin/elements/forms/field.html" with field=edit_form.author_job_title %}
{% include "admin/elements/forms/field.html" with field=edit_form.author_department %}
{% include "admin/elements/forms/field.html" with field=edit_form.author_affiliation_dates %}
</div>
3 changes: 0 additions & 3 deletions src/templates/admin/elements/forms/group_submission.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,6 @@ <h2>Text</h2>
{% include "admin/elements/forms/field.html" with field=edit_form.publication_cycle %}
{% include "admin/elements/forms/field.html" with field=edit_form.peer_review_info %}
{% include "admin/elements/forms/field.html" with field=edit_form.acceptance_criteria %}
{% include "admin/elements/forms/field.html" with field=edit_form.author_job_title %}
{% include "admin/elements/forms/field.html" with field=edit_form.author_department %}
{% include "admin/elements/forms/field.html" with field=edit_form.author_affiliation_dates %}
</div>

<div class="title-area">
Expand Down
Loading