Skip to content

fix(client): detach InputHandler listeners on destroy and destroy it when the game stops (OPE-411) #5385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Celant wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix(client): detach InputHandler listeners on destroy and destroy it when the game stops (OPE-411) #5385

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
588f682
fix(client): detach InputHandler listeners and keybinds on destroy (O…
Celant Sep 12, 2026
35f005a
fix(client): destroy the InputHandler when the game stops (OPE-411)
Celant Sep 12, 2026
d36adbe
test(client): make the InputHandler teardown tests actually detect a …
Celant Sep 12, 2026
dd208c6
fix(client): cancel the pending long-press timer on teardown (OPE-411)
Celant Sep 12, 2026
7bf069f
fix(client): release the InputHandler's EventBus subscription on dest…
Celant Sep 12, 2026
6e546de
fix(client): drop in-flight pointer state on teardown and re-initiali…
Celant Sep 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/client/ClientGameRunner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1121,6 +1121,11 @@ export class ClientGameRunner {
public stop() {
this.soundManager.dispose();
this.graphicsListenerAbort?.abort();
// Detach the input handler's window/canvas listeners. Nothing else ever
// did, so a handler from a finished game kept translating keys into events
// on a dead bus, and joining another game without a page reload stacked a
// second live handler on top. Idempotent, like the disposals around it.
this.input.destroy();
this.disposeRenderer?.();
if (!this.isActive) return;

Expand Down
Loading
Loading