Skip to content

Check age before assigning object #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tumbledwyer merged 2 commits into from
Feb 13, 2026
Merged

Check age before assigning object #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc21601
Check age before assigning object
tumbledwyer Feb 12, 2026
c7f2635
Fix test related to previous PR
tumbledwyer Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions v1-to-v2-data-migration/helpers/defaultResolvers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,10 +137,11 @@ export const defaultDeathResolver: ResolverMap = {
'deceased.dob': (data: EventRegistration) => data.deceased?.birthDate,
'deceased.dobUnknown': (data: EventRegistration) =>
data.deceased?.exactDateOfBirthUnknown,
'deceased.age': (data: EventRegistration) => ({
age: data.deceased?.ageOfIndividualInYears,
asOfDateRef: 'eventDetails.date',
}),
'deceased.age': (data: EventRegistration) =>
data.deceased?.ageOfIndividualInYears && {
age: data.deceased?.ageOfIndividualInYears,
asOfDateRef: 'eventDetails.date',
},
'deceased.nationality': (data: EventRegistration) =>
data.deceased?.nationality?.[0],
'deceased.idType': (data: EventRegistration) =>
Expand Down Expand Up @@ -205,10 +206,11 @@ export const defaultDeathResolver: ResolverMap = {
'spouse.dob': (data: EventRegistration) => data.spouse?.birthDate,
'spouse.dobUnknown': (data: EventRegistration) =>
data.spouse?.exactDateOfBirthUnknown,
'spouse.age': (data: EventRegistration) => ({
age: data.spouse?.ageOfIndividualInYears,
asOfDateRef: 'eventDetails.date',
}),
'spouse.age': (data: EventRegistration) =>
data.spouse?.ageOfIndividualInYears && {
age: data.spouse?.ageOfIndividualInYears,
asOfDateRef: 'eventDetails.date',
},
'spouse.nationality': (data: EventRegistration) =>
data.spouse?.nationality?.[0],
'spouse.idType': (data: EventRegistration) =>
Expand Down
9 changes: 8 additions & 1 deletion v1-to-v2-data-migration/tests/unit/actionMapping.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,14 @@ Deno.test('transform - basic action type mappings', async (t) => {
await t.step(
'should map WAITING_VALIDATION regStatus to REGISTER action with Requested status',
() => {
const history = [buildHistoryItem({ regStatus: 'WAITING_VALIDATION' })]
const acceptedRegisterAction = buildHistoryItem({
regStatus: 'REGISTERED'
})

const history = [
buildHistoryItem({ regStatus: 'WAITING_VALIDATION' }),
acceptedRegisterAction
]
const registration = buildEventRegistration({ history })

const result = transform(registration, {}, 'birth')
Expand Down