increase bias

[hmod2001]

Update TRANSCEIVER-9_ZRP laser bias current validation to allow the full CMIS-scaled range for modules using the x4 laser-bias-current multiplier.

The failing optic reported 219.9 mA, which is valid for the observed CMIS multiplier. The previous test limit of 131 mA only covered the base 2 uA LSB range and falsely failed valid telemetry.

Evidence
CMIS laser bias current encoding uses a 16-bit unsigned value with an LSB of 2 uA multiplied by the scale factor from Page 01h, Byte 160.

https://www.oiforum.com/wp-content/uploads/CMIS3p0_Third_Party_Spec.pdf

Observed module data:

Page 01h Byte 160 = 0x17
bits [4:3] = 10b
10b => x4 multiplier

Maximum valid value for x4 multiplier:
65535 * 2 uA * 4 = 524280 uA
524280 uA = 524.28 mA

Pass logs: https://firex-north.cisco.com/auto/firex-logs-ott-2/b4-featureprofiles/FireX-mananpat-260913-154059-26183/tests_logs/TRANSCEIVER_9_B4CE55F8/

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the validation logic for the ZRP laser bias current test to accommodate higher current ranges specified by the CMIS standard. The previous hardcoded limit was insufficient for modules using x4 scaling, leading to false failures for valid telemetry data.

Highlights

• Updated Laser Bias Validation Limit: Increased the maximum allowed laser bias current threshold from 131 mA to 524.28 mA to correctly support modules utilizing the x4 CMIS-scaled multiplier.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[OpenConfigBot]

Pull Request Functional Test Report for #6054 / 46da2b2

Virtual Devices

Device	Test	Status	Test Documentation	Job	Raw Log
Arista cEOS		TRANSCEIVER-9.2: pending authorization	TRANSCEIVER-9.2: Telemetry: 400ZR_PLUS TX laser bias current telemetry values streaming.
Cisco 8000E		TRANSCEIVER-9.2: pending authorization	TRANSCEIVER-9.2: Telemetry: 400ZR_PLUS TX laser bias current telemetry values streaming.
Cisco XRd		TRANSCEIVER-9.2: pending authorization	TRANSCEIVER-9.2: Telemetry: 400ZR_PLUS TX laser bias current telemetry values streaming.
Juniper ncPTX		TRANSCEIVER-9.2: pending authorization	TRANSCEIVER-9.2: Telemetry: 400ZR_PLUS TX laser bias current telemetry values streaming.
Nokia SR Linux		TRANSCEIVER-9.2: pending authorization	TRANSCEIVER-9.2: Telemetry: 400ZR_PLUS TX laser bias current telemetry values streaming.
Openconfig Lemming		TRANSCEIVER-9.2: pending authorization	TRANSCEIVER-9.2: Telemetry: 400ZR_PLUS TX laser bias current telemetry values streaming.

Hardware Devices

Device	Test	Status	Test Documentation	Raw Log
Arista		TRANSCEIVER-9.2: pending authorization	TRANSCEIVER-9.2: Telemetry: 400ZR_PLUS TX laser bias current telemetry values streaming.
Cisco		TRANSCEIVER-9.2: pending authorization	TRANSCEIVER-9.2: Telemetry: 400ZR_PLUS TX laser bias current telemetry values streaming.
Juniper		TRANSCEIVER-9.2: pending authorization	TRANSCEIVER-9.2: Telemetry: 400ZR_PLUS TX laser bias current telemetry values streaming.
Nokia		TRANSCEIVER-9.2: pending authorization	TRANSCEIVER-9.2: Telemetry: 400ZR_PLUS TX laser bias current telemetry values streaming.

Help

[gemini-code-assist]

Code Review

This pull request updates the upper limit validation for the laser bias value from 131.0 to 524.28 in the transceiver test. Feedback points out that the error message still references the old limit of 131 and needs to be updated to match the new validation logic.

[danielbarney]

/fptest virtual