Add sFlow Egress Sampling test README - #6025
Conversation
Pull Request Functional Test Report for #6025 / 64beee2Virtual Devices
Hardware Devices
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces the documentation and registry entry for the SFLOW-2 test case, which focuses on verifying egress sFlow sampling on network devices. The changes outline the required OpenConfig paths, testbed topology, and verification procedures for ensuring that egress-sampled packets are correctly captured and reported by the DUT. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces the test plan for SFLOW-2 (sFlow Egress Sampling Configuration and Verification) and registers it in the test registry. The review feedback highlights a syntax error in the protobuf registry file (using tests { instead of test: {) and a repository style guide violation where the test plan document should be named README.md instead of sflow_egress_test_README.md.
bb2a954 to
be0735f
Compare
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
be0735f to
64beee2
Compare
This PR adds the test requirements (README.md) for SFLOW-2: sFlow Egress Sampling Configuration and Verification.
While standard sFlow sampling captures packets at the ingress pipeline, egress sFlow enables sampling of packets as they egress the device (post-encapsulation and routing header modifications). This test qualifies OpenConfig configuration, operational state telemetry, and flow sample verification for interface-level egress sampling on supported platforms.
Key Coverage
SFLOW-2topologies/atedut_2.testbed/sampling/sflow/interfaces/interface/config/egress-sampling-rate/sampling/sflow/interfaces/interface/state/egress-sampling-rate/sampling/sflow/interfaces/interface/state/enabled/sampling/sflow/config/enabled, etc.)SFLOW-2.1: Configure interface-level egress sampling rate via gNMI Replace and verify telemetry state.SFLOW-2.2: Transmit data traffic through the DUT and verify that captured sFlow datagrams report the correct egress output interface (ifIndex) and adhere to the configured sampling rate.SFLOW-2.3: Disable egress sampling and verify clean teardown.