Skip to content

Add sFlow Egress Sampling test README - #6025

Open
alexmihoc-google wants to merge 2 commits into
mainfrom
feature/slflow-egress-test
Open

Add sFlow Egress Sampling test README#6025
alexmihoc-google wants to merge 2 commits into
mainfrom
feature/slflow-egress-test

Conversation

@alexmihoc-google

Copy link
Copy Markdown

This PR adds the test requirements (README.md) for SFLOW-2: sFlow Egress Sampling Configuration and Verification.

While standard sFlow sampling captures packets at the ingress pipeline, egress sFlow enables sampling of packets as they egress the device (post-encapsulation and routing header modifications). This test qualifies OpenConfig configuration, operational state telemetry, and flow sample verification for interface-level egress sampling on supported platforms.

Key Coverage

  • Test ID: SFLOW-2
  • Testbed: topologies/atedut_2.testbed
  • OpenConfig Paths Covered:
    • /sampling/sflow/interfaces/interface/config/egress-sampling-rate
    • /sampling/sflow/interfaces/interface/state/egress-sampling-rate
    • /sampling/sflow/interfaces/interface/state/enabled
    • Global sFlow collector and enablement paths (/sampling/sflow/config/enabled, etc.)
  • Test Scenarios:
    • SFLOW-2.1: Configure interface-level egress sampling rate via gNMI Replace and verify telemetry state.
    • SFLOW-2.2: Transmit data traffic through the DUT and verify that captured sFlow datagrams report the correct egress output interface (ifIndex) and adhere to the configured sampling rate.
    • SFLOW-2.3: Disable egress sampling and verify clean teardown.

@alexmihoc-google
alexmihoc-google requested a review from a team as a code owner September 11, 2026 11:11
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces the documentation and registry entry for the SFLOW-2 test case, which focuses on verifying egress sFlow sampling on network devices. The changes outline the required OpenConfig paths, testbed topology, and verification procedures for ensuring that egress-sampled packets are correctly captured and reported by the DUT.

Highlights

  • New Test Documentation: Added a comprehensive README for the SFLOW-2 test case, covering egress sFlow sampling configuration, telemetry validation, and traffic verification.
  • Test Registry Update: Registered the new SFLOW-2 test case in the global test registry to include it in the test suite tracking.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the test plan for SFLOW-2 (sFlow Egress Sampling Configuration and Verification) and registers it in the test registry. The review feedback highlights a syntax error in the protobuf registry file (using tests { instead of test: {) and a repository style guide violation where the test plan document should be named README.md instead of sflow_egress_test_README.md.

Comment thread testregistry.textproto Outdated
Comment thread feature/sflow/otg_tests/sflow_egress_test/README.md
@alexmihoc-google
alexmihoc-google force-pushed the feature/slflow-egress-test branch 2 times, most recently from bb2a954 to be0735f Compare September 11, 2026 13:33
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@alexmihoc-google
alexmihoc-google force-pushed the feature/slflow-egress-test branch from be0735f to 64beee2 Compare September 11, 2026 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants