Adding RT-5.17 Physical Interface Drain via Admin Down

[Steubert]

README: https://github.com/openconfig/featureprofiles/blob/82d398a09b35fcc8eb531594f0046a5dbfd2c950/feature/interface/singleton/otg_tests/interface_admin_drain_test/README.md

Logs: https://partnerissuetracker.corp.google.com/u/1/issues/559518011

[OpenConfigBot]

Pull Request Functional Test Report for #6024 / c97351f

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		RT-5.17: Physical Interface Drain via Admin Down
Cisco 8000E		RT-5.17: Physical Interface Drain via Admin Down
Cisco XRd		RT-5.17: Physical Interface Drain via Admin Down
Juniper ncPTX		RT-5.17: Physical Interface Drain via Admin Down
Nokia SR Linux		RT-5.17: Physical Interface Drain via Admin Down
Openconfig Lemming		RT-5.17: Physical Interface Drain via Admin Down

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista		RT-5.17: Physical Interface Drain via Admin Down
Cisco		RT-5.17: Physical Interface Drain via Admin Down
Juniper		RT-5.17: Physical Interface Drain via Admin Down
Nokia		RT-5.17: Physical Interface Drain via Admin Down

Help

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces an automated test suite to verify the behavior of physical interface draining using administrative down commands. The implementation ensures that BGP sessions and IS-IS adjacencies are correctly torn down, forwarding is halted on the affected interface, and traffic on other ports remains unaffected. The changes also include utility enhancements to support protocol state verification and bidirectional traffic flow configuration.

Highlights

• New Test Implementation: Added a new test case for RT-5.17 to validate physical interface draining via administrative down, ensuring correct protocol teardown and traffic behavior.
• Enhanced Verification Helpers: Introduced new helper functions in cfgplugins for verifying BGP neighbor session states and IS-IS adjacency states.
• OTG Flow Support: Updated otgflowhelpers to support bidirectional traffic streams, allowing for more flexible test traffic configuration.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request implements the RT-5.17 Physical Interface Drain via Admin Down test plan, validating protocol teardown and traffic restoration when an interface is disabled and re-enabled. It introduces helper functions in cfgplugins for BGP and IS-IS state verification and adds bidirectional flow support in OTG helpers. The review feedback highlights a critical style guide violation in internal/cfgplugins/isis.go, where a custom polling loop with time.Sleep is used instead of the mandatory gnmi.Watch API.